Change diagnostics action to use paths.TempDir #8472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
bug
michel-laterman
force-pushed
the
fix-diagnostics-temp-dir
branch
from
c171a19 to
601b99a
Compare
Contributor
Author
|
buildkite test this |
|
Contributor
💚 Build Succeeded
History
|
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
swiatekm
approved these changes
Jun 13, 2025
kaanyalti
approved these changes
Jun 17, 2025
Contributor
|
@Mergifyio backport 8.17 8.18 8.19 9.0 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
(cherry picked from commit e4258ea)
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
(cherry picked from commit e4258ea)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
(cherry picked from commit e4258ea)
This was referenced Jun 17, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
(cherry picked from commit e4258ea)
3 tasks
michel-laterman
added a commit
that referenced
this pull request
Jun 18, 2025
michel-laterman
added a commit
that referenced
this pull request
Jun 18, 2025
michel-laterman
added a commit
that referenced
this pull request
Jun 18, 2025
michel-laterman
added a commit
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the diagnostics action handler to use the temp dir from
paths.TempDirinstead of the default one inferred byos.CreateTemp.Why is it important?
The agent should use paths it has definitions for instead of OS defaults.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testDisruptive User Impact
N/A
How to test this PR locally
elastic-agent diagnostics