-
Notifications
You must be signed in to change notification settings - Fork 203
[Synthetics] Add e2e test for synthetics deps in complete variants #8605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
💚 Build Succeeded
cc @emilioalvap |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
vigneshshanmugam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
@elastic/elastic-agent-control-plane please provide a review as CODEOWNERS. |
|
@Mergifyio backport 8.17 8.18 8.19 9.0 |
✅ Backports have been created
|
… in complete variants (#8677) * [Synthetics] Add e2e test for synthetics deps in complete variants (#8605) * Add docker integration test for synthetics deps (cherry picked from commit f8c1f2e) # Conflicts: # dev-tools/packaging/package_test.go * Fix merge conflicts --------- Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co> Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
… in complete variants (#8679) * [Synthetics] Add e2e test for synthetics deps in complete variants (#8605) * Add docker integration test for synthetics deps (cherry picked from commit f8c1f2e) # Conflicts: # dev-tools/packaging/testing/package_test.go * Fix merge conflicts --------- Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co>
… in complete variants (#8678) * [Synthetics] Add e2e test for synthetics deps in complete variants (#8605) * Add docker integration test for synthetics deps (cherry picked from commit f8c1f2e) # Conflicts: # dev-tools/packaging/package_test.go * Fix merge conflicts --------- Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co>





What does this PR do?
Add tests to check synthetics dependencies for complete variant docker packages. These will prevent the possibility of an unrelated change removing the required dependencies.
Why is it important?
We have seen instances where unrelated changes to the docker template have caused the generated
-completevariants to be missing synthetics dependencies.Checklist
[] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog toolHow to test this PR locally
Related issues