Skip to content

Conversation

@emilioalvap
Copy link
Contributor

What does this PR do?

Add tests to check synthetics dependencies for complete variant docker packages. These will prevent the possibility of an unrelated change removing the required dependencies.

Why is it important?

We have seen instances where unrelated changes to the docker template have caused the generated -complete variants to be missing synthetics dependencies.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

How to test this PR locally

  1. Edit elastic-agent docker template sections where synthetics-deps are installed.
  2. Build agent locally.
  3. Wait for testing step to fail.
  4. Restore elastic-agent template.
  5. Build and wait for completion.

Related issues

@emilioalvap emilioalvap requested a review from a team as a code owner June 20, 2025 13:37
@emilioalvap emilioalvap added chore Tasks that just need to be done, they are neither bug, nor enhancements Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-active-all Automated backport with mergify to all the active branches labels Jun 20, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @emilioalvap

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 20, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elastic-sonarqube
Copy link

@emilioalvap emilioalvap enabled auto-merge (squash) June 23, 2025 14:25
@emilioalvap
Copy link
Contributor Author

@elastic/elastic-agent-control-plane please provide a review as CODEOWNERS.

@emilioalvap emilioalvap merged commit f8c1f2e into main Jun 25, 2025
19 checks passed
@emilioalvap emilioalvap deleted the issue-8434-synthetics-e2e-test branch June 25, 2025 18:29
@github-actions
Copy link
Contributor

@Mergifyio backport 8.17 8.18 8.19 9.0

@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2025

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 25, 2025
…8605)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)

# Conflicts:
#	dev-tools/packaging/package_test.go
mergify bot pushed a commit that referenced this pull request Jun 25, 2025
…8605)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)

# Conflicts:
#	dev-tools/packaging/package_test.go
mergify bot pushed a commit that referenced this pull request Jun 25, 2025
…8605)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)

# Conflicts:
#	dev-tools/packaging/testing/package_test.go
mergify bot pushed a commit that referenced this pull request Jun 25, 2025
…8605)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)
ycombinator pushed a commit that referenced this pull request Jun 26, 2025
…8605) (#8680)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
pkoutsovasilis added a commit that referenced this pull request Jul 1, 2025
… in complete variants (#8677)

* [Synthetics] Add e2e test for synthetics deps in complete variants (#8605)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)

# Conflicts:
#	dev-tools/packaging/package_test.go

* Fix merge conflicts

---------

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co>
Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
emilioalvap added a commit that referenced this pull request Jul 1, 2025
… in complete variants (#8679)

* [Synthetics] Add e2e test for synthetics deps in complete variants (#8605)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)

# Conflicts:
#	dev-tools/packaging/testing/package_test.go

* Fix merge conflicts

---------

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co>
emilioalvap added a commit that referenced this pull request Jul 2, 2025
… in complete variants (#8678)

* [Synthetics] Add e2e test for synthetics deps in complete variants (#8605)

* Add docker integration test for synthetics deps

(cherry picked from commit f8c1f2e)

# Conflicts:
#	dev-tools/packaging/package_test.go

* Fix merge conflicts

---------

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches chore Tasks that just need to be done, they are neither bug, nor enhancements skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:obs-ds-hosted-services Label for the Observability Hosted Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants