Enhancement/5235 handle insufficient disk space errors in artifact unpack #9322

kaanyalti · 2025-08-12T14:28:55Z

PR 2/6

Enhancement

What does this PR do?

This is a follow up on Enhancement/5235 insufficient disk handling retry shows underlying error #9122.
Introduces disk space error type and relevant functions
Modifies the upgrader unpack step to wrap errors so that the errors are propagated correctly.
Adds relevant tests, asserts that errors, specifically the disk space error, get propagated up the call chain.

Why is it important?

Non-wrapped errors mask the underlying disk space error when using errors.Is. This is need to address the original issue.

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
~~[ ] I have made corresponding changes to the documentation~~
~~[ ] I have made corresponding change to the default configuration files~~
I have added tests that prove my fix is effective or that my feature works
~~[ ] I have added an entry in ./changelog/fragments using the changelog tool~~
I have added an integration test or an E2E test

Disruptive User Impact

If the agent runs into disk space errors when it is unpacking the downloaded agent archive, the status and fleet ui will show "insufficient disk space" as the error message

How to test this PR locally

Build for windows, mac, linux
Install agent (managed and standalone)
Fill up disk until there is approximately 500mb left
Trigger upgrade
- From fleet
- Cli with remote url and file
Validate the upgrade detail error message shows insufficient disk error message both in the status output and on fleet ui.
Run the upgrade, step_unpack tests

Related issues

mergify · 2025-08-12T14:29:36Z

This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

elasticmachine · 2025-08-12T14:30:28Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

kaanyalti · 2025-08-13T12:00:19Z

Accidentally pushed the wrong remote branch name to delete, reopened after re-publishing branch.

kaanyalti · 2025-08-13T12:05:23Z

nolint:gosec linting error is fixed in #9347

mergify · 2025-08-13T19:18:42Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack upstream/enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack
git merge upstream/main
git push upstream enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack

internal/pkg/agent/application/upgrade/step_unpack_test.go

internal/pkg/agent/application/upgrade/upgrade_test.go

internal/pkg/agent/application/upgrade/step_unpack.go

elastic-sonarqube · 2025-09-08T23:49:51Z

Quality Gate passed

Issues
3 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
93.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

elasticmachine · 2025-09-09T01:13:36Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: d5032a6

Failed CI Steps

History

💛 Build #26369 was flaky 829bf60
💔 Build #26364 failed 4a7b718
💚 Build #26180 succeeded 381d5a5
💔 Build #26163 failed 722b9ec
💚 Build #26070 succeeded d284c1e
💔 Build #26058 failed d284c1e

cc @kaanyalti

github-actions · 2025-09-09T01:16:29Z

@Mergifyio backport 8.18 8.19 9.0 9.1

mergify · 2025-09-09T01:16:38Z

backport 8.18 8.19 9.0 9.1

✅ Backports have been created

#9818 [8.18] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack has been created for branch 8.18 but encountered conflicts
#9819 [8.19] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack has been created for branch 8.19 but encountered conflicts
#9820 [9.0] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack has been created for branch 9.0 but encountered conflicts
#9821 [9.1] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack has been created for branch 9.1

…pack (#9322) * enhancement(5235): added stdlib wrappers in step_unpack * enhancement(5235): wrap errors in step_unpack * enhancement(5235): removed nolint:gosec comment from step_unpack * enhancement(5235): refactored unpack step to abstract the unpack function from upgrader. abstracted unzip and untar to be able to test unpack function. updated unpack step tests to test for stdlib failures in unzip and untar and added tests for unpack * enhancement(5235}: added unpackHandler interface to abstract the unpack function from upgrader * enhancement(5235): added getPackageMetadata into unpackHandler interface for testability * enhancement(5235): using unpacker.getPackageMetadata * enhancement(5235): added abstractions in upgrader for testability * enhancement(5235): removed unpack specific test from upgrade tests, added test cases in the upgrade error handling test * enhancement(5235): using formatted test assertion api (cherry picked from commit f70ff02) # Conflicts: # internal/pkg/agent/application/upgrade/step_unpack.go # internal/pkg/agent/application/upgrade/step_unpack_test.go # internal/pkg/agent/application/upgrade/upgrade.go

…pack (#9322) * enhancement(5235): added stdlib wrappers in step_unpack * enhancement(5235): wrap errors in step_unpack * enhancement(5235): removed nolint:gosec comment from step_unpack * enhancement(5235): refactored unpack step to abstract the unpack function from upgrader. abstracted unzip and untar to be able to test unpack function. updated unpack step tests to test for stdlib failures in unzip and untar and added tests for unpack * enhancement(5235}: added unpackHandler interface to abstract the unpack function from upgrader * enhancement(5235): added getPackageMetadata into unpackHandler interface for testability * enhancement(5235): using unpacker.getPackageMetadata * enhancement(5235): added abstractions in upgrader for testability * enhancement(5235): removed unpack specific test from upgrade tests, added test cases in the upgrade error handling test * enhancement(5235): using formatted test assertion api (cherry picked from commit f70ff02) # Conflicts: # internal/pkg/agent/application/upgrade/step_unpack_test.go

…pack (#9322) * enhancement(5235): added stdlib wrappers in step_unpack * enhancement(5235): wrap errors in step_unpack * enhancement(5235): removed nolint:gosec comment from step_unpack * enhancement(5235): refactored unpack step to abstract the unpack function from upgrader. abstracted unzip and untar to be able to test unpack function. updated unpack step tests to test for stdlib failures in unzip and untar and added tests for unpack * enhancement(5235}: added unpackHandler interface to abstract the unpack function from upgrader * enhancement(5235): added getPackageMetadata into unpackHandler interface for testability * enhancement(5235): using unpacker.getPackageMetadata * enhancement(5235): added abstractions in upgrader for testability * enhancement(5235): removed unpack specific test from upgrade tests, added test cases in the upgrade error handling test * enhancement(5235): using formatted test assertion api (cherry picked from commit f70ff02)

…pack (#9322) (#9821) * enhancement(5235): added stdlib wrappers in step_unpack * enhancement(5235): wrap errors in step_unpack * enhancement(5235): removed nolint:gosec comment from step_unpack * enhancement(5235): refactored unpack step to abstract the unpack function from upgrader. abstracted unzip and untar to be able to test unpack function. updated unpack step tests to test for stdlib failures in unzip and untar and added tests for unpack * enhancement(5235}: added unpackHandler interface to abstract the unpack function from upgrader * enhancement(5235): added getPackageMetadata into unpackHandler interface for testability * enhancement(5235): using unpacker.getPackageMetadata * enhancement(5235): added abstractions in upgrader for testability * enhancement(5235): removed unpack specific test from upgrade tests, added test cases in the upgrade error handling test * enhancement(5235): using formatted test assertion api (cherry picked from commit f70ff02) Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>

…e errors in artifact unpack (#9820) * Enhancement/5235 handle insufficient disk space errors in artifact unpack (#9322) * enhancement(5235): added stdlib wrappers in step_unpack * enhancement(5235): wrap errors in step_unpack * enhancement(5235): removed nolint:gosec comment from step_unpack * enhancement(5235): refactored unpack step to abstract the unpack function from upgrader. abstracted unzip and untar to be able to test unpack function. updated unpack step tests to test for stdlib failures in unzip and untar and added tests for unpack * enhancement(5235}: added unpackHandler interface to abstract the unpack function from upgrader * enhancement(5235): added getPackageMetadata into unpackHandler interface for testability * enhancement(5235): using unpacker.getPackageMetadata * enhancement(5235): added abstractions in upgrader for testability * enhancement(5235): removed unpack specific test from upgrade tests, added test cases in the upgrade error handling test * enhancement(5235): using formatted test assertion api (cherry picked from commit f70ff02) # Conflicts: # internal/pkg/agent/application/upgrade/step_unpack_test.go * resolve conflicts --------- Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>

…ce errors in artifact unpack (#9819) * Enhancement/5235 handle insufficient disk space errors in artifact unpack (#9322) * enhancement(5235): added stdlib wrappers in step_unpack * enhancement(5235): wrap errors in step_unpack * enhancement(5235): removed nolint:gosec comment from step_unpack * enhancement(5235): refactored unpack step to abstract the unpack function from upgrader. abstracted unzip and untar to be able to test unpack function. updated unpack step tests to test for stdlib failures in unzip and untar and added tests for unpack * enhancement(5235}: added unpackHandler interface to abstract the unpack function from upgrader * enhancement(5235): added getPackageMetadata into unpackHandler interface for testability * enhancement(5235): using unpacker.getPackageMetadata * enhancement(5235): added abstractions in upgrader for testability * enhancement(5235): removed unpack specific test from upgrade tests, added test cases in the upgrade error handling test * enhancement(5235): using formatted test assertion api (cherry picked from commit f70ff02) # Conflicts: # internal/pkg/agent/application/upgrade/step_unpack.go # internal/pkg/agent/application/upgrade/step_unpack_test.go # internal/pkg/agent/application/upgrade/upgrade.go * resolve conflicts --------- Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>

…ce errors in artifact unpack (#9818) * Enhancement/5235 handle insufficient disk space errors in artifact unpack (#9322) * enhancement(5235): added stdlib wrappers in step_unpack * enhancement(5235): wrap errors in step_unpack * enhancement(5235): removed nolint:gosec comment from step_unpack * enhancement(5235): refactored unpack step to abstract the unpack function from upgrader. abstracted unzip and untar to be able to test unpack function. updated unpack step tests to test for stdlib failures in unzip and untar and added tests for unpack * enhancement(5235}: added unpackHandler interface to abstract the unpack function from upgrader * enhancement(5235): added getPackageMetadata into unpackHandler interface for testability * enhancement(5235): using unpacker.getPackageMetadata * enhancement(5235): added abstractions in upgrader for testability * enhancement(5235): removed unpack specific test from upgrade tests, added test cases in the upgrade error handling test * enhancement(5235): using formatted test assertion api (cherry picked from commit f70ff02) # Conflicts: # internal/pkg/agent/application/upgrade/step_unpack.go # internal/pkg/agent/application/upgrade/step_unpack_test.go # internal/pkg/agent/application/upgrade/upgrade.go * resolve conflicts --------- Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co> Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>

…pack (elastic#9322) * enhancement(5235): added stdlib wrappers in step_unpack * enhancement(5235): wrap errors in step_unpack * enhancement(5235): removed nolint:gosec comment from step_unpack * enhancement(5235): refactored unpack step to abstract the unpack function from upgrader. abstracted unzip and untar to be able to test unpack function. updated unpack step tests to test for stdlib failures in unzip and untar and added tests for unpack * enhancement(5235}: added unpackHandler interface to abstract the unpack function from upgrader * enhancement(5235): added getPackageMetadata into unpackHandler interface for testability * enhancement(5235): using unpacker.getPackageMetadata * enhancement(5235): added abstractions in upgrader for testability * enhancement(5235): removed unpack specific test from upgrade tests, added test cases in the upgrade error handling test * enhancement(5235): using formatted test assertion api

kaanyalti marked this pull request as ready for review August 12, 2025 14:29

kaanyalti requested a review from a team as a code owner August 12, 2025 14:29

kaanyalti requested review from michel-laterman and pkoutsovasilis August 12, 2025 14:29

mergify bot assigned kaanyalti Aug 12, 2025

kaanyalti added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-active-all Automated backport with mergify to all the active branches labels Aug 12, 2025

kaanyalti added the skip-changelog label Aug 12, 2025

kaanyalti marked this pull request as draft August 12, 2025 14:31

kaanyalti mentioned this pull request Aug 12, 2025

Enhancement/5235 insufficient disk handling retry shows underlying error #9122

Merged

6 tasks

kaanyalti force-pushed the enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack branch 3 times, most recently from c264d61 to 802866c Compare August 13, 2025 11:22

kaanyalti marked this pull request as ready for review August 13, 2025 11:45

kaanyalti closed this Aug 13, 2025

kaanyalti deleted the enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack branch August 13, 2025 11:53

kaanyalti restored the enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack branch August 13, 2025 11:58

kaanyalti reopened this Aug 13, 2025

kaanyalti mentioned this pull request Aug 13, 2025

enhancement(5235): moved nolint:gosec comment to #9347

Merged

1 task

kaanyalti force-pushed the enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack branch 3 times, most recently from e81981e to 00793b2 Compare August 13, 2025 19:14

This was referenced Aug 13, 2025

[8.17] (backport #9347) enhancement(5235): moved nolint:gosec comment to #9350

Merged

[8.18] (backport #9347) enhancement(5235): moved nolint:gosec comment to #9351

Merged

[8.19] (backport #9347) enhancement(5235): moved nolint:gosec comment to #9352

Merged

kaanyalti force-pushed the enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack branch from 4a7b718 to 829bf60 Compare September 8, 2025 14:58

kaanyalti marked this pull request as ready for review September 8, 2025 17:40

kaanyalti requested a review from pkoutsovasilis September 8, 2025 17:40

michel-laterman reviewed Sep 8, 2025

View reviewed changes

enhancement(5235): using formatted test assertion api

d5032a6

kaanyalti requested a review from michel-laterman September 8, 2025 22:18

michel-laterman approved these changes Sep 8, 2025

View reviewed changes

kaanyalti merged commit f70ff02 into elastic:main Sep 9, 2025
23 checks passed

kaanyalti deleted the enhancement/5235_handle_insufficient_disk_space_errors_in_artifact_unpack branch September 9, 2025 01:16

mergify bot mentioned this pull request Sep 9, 2025

[8.18] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack #9818

Merged

5 tasks

This was referenced Sep 9, 2025

[8.19] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack #9819

Merged

[9.0] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack #9820

Merged

mergify bot mentioned this pull request Sep 9, 2025

[9.1] (backport #9322) Enhancement/5235 handle insufficient disk space errors in artifact unpack #9821

Merged

5 tasks

Enhancement/5235 handle insufficient disk space errors in artifact unpack #9322

Enhancement/5235 handle insufficient disk space errors in artifact unpack #9322

Uh oh!

Conversation

kaanyalti commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Uh oh!

mergify bot commented Aug 12, 2025

Uh oh!

elasticmachine commented Aug 12, 2025

Uh oh!

kaanyalti commented Aug 13, 2025

Uh oh!

kaanyalti commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Aug 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elastic-sonarqube bot commented Sep 8, 2025

Quality Gate passed

Uh oh!

elasticmachine commented Sep 9, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

Uh oh!

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

mergify bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kaanyalti commented Aug 12, 2025 •

edited

Loading

kaanyalti commented Aug 13, 2025 •

edited

Loading

mergify bot commented Sep 9, 2025 •

edited

Loading