Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis domain fit option to include also annotation's data #1411

Closed
dej611 opened this issue Sep 27, 2021 · 1 comment · Fixed by #1641
Closed

Axis domain fit option to include also annotation's data #1411

dej611 opened this issue Sep 27, 2021 · 1 comment · Fixed by #1641
Assignees
Labels
:annotation Annotation (line, rect, text) related issue :axis Axis related issue enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :Lens Kibana Lens related issue :xy Bar/Line/Area chart related

Comments

@dej611
Copy link
Contributor

dej611 commented Sep 27, 2021

Is your feature request related to a problem? Please describe.
While working on the new threshold feature in Lens, using the annotation components from this library, we found the need to use an automatic fit that would include also annotations in the domain calculation.

Describe the solution you'd like
Having a fit option to fit the data in the chart, including the annotation one.

Describe alternatives you've considered
Doing it manually on consumer side.

Kibana Cross Issues
elastic/kibana#112795
elastic/kibana#129240

@dej611 dej611 added enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :axis Axis related issue :annotation Annotation (line, rect, text) related issue :xy Bar/Line/Area chart related :Lens Kibana Lens related issue labels Sep 27, 2021
@flash1293
Copy link

@markov00 Fixing this would allow us to get rid of a bug (elastic/kibana#129240) as well as removing some custom logic: https://github.com/elastic/kibana/blob/072fe63c0b326f6dfd0215cda648c982f4b6bee8/src/plugins/chart_expressions/expression_xy/public/components/xy_chart.tsx#L351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:annotation Annotation (line, rect, text) related issue :axis Axis related issue enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :Lens Kibana Lens related issue :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants