Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Thresholds: chart bounds should be automatically extended to include threshold lines #112795

Closed
Tracked by #57706
dej611 opened this issue Sep 22, 2021 · 7 comments · Fixed by #113238
Closed
Tracked by #57706
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dej611
Copy link
Contributor

dej611 commented Sep 22, 2021

Describe the feature:

Dynamically change the visualization bounds based on the threshold value.

@dej611 dej611 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@ghudgins
Copy link

ghudgins commented Sep 22, 2021

CC @elastic/datavis for their thoughts on this....I personally think it makes sense

@nickofthyme
Copy link
Contributor

This is good idea but I'd say it should be non-default behavior. Focusing the chart to the extents of the data is more important to me and including the threshold only if applicable.

@markov00
Copy link
Member

As already proposed in a meeting, annotations like thresholds can be treated as actual chart data, so we should show the threshold line and increase the boundaries of the chart when required. We can provide the ability to visualize the threshold in the legend and add the ability to hide/show them to restore the, eventually, extended domain

@ghudgins
Copy link

++ thanks @markov00 - these 2 issues would help provide more value to thresholds in this case but also generally elastic/elastic-charts#299 & elastic/elastic-charts#555

@flash1293
Copy link
Contributor

We can provide the ability to visualize the threshold in the legend and add the ability to hide/show them

This would be really cool!

@flash1293
Copy link
Contributor

We decided to go forward with including thresholds in the auto bounds for now (custom bounds will be respected). Once the linked elastic-charts features are added, we can introduce them on top in a separate task.

@flash1293 flash1293 changed the title [Lens] Thresholds: should chart bounds be automatically extended to include threshold lines? [Lens] Thresholds: chart bounds should be automatically extended to include threshold lines Sep 23, 2021
@dej611 dej611 self-assigned this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants