-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the startOfWeek
+ month + year
multi-layer time raster
#1934
Comments
I see the issue regarding the day/month cross over at the start of some new months but I think the real issue is how we handle the general sticky interval label behavior. this behavior of showing the previous tick interval is a little strange when the tick is no longer visible. Screen.Recording.2023-01-17.at.02.50.41.PM.mp4Take the screenshot below for example... Looking at the I imagine the benefit of this behavior is to give the user the best context of the current time interval and rather than having then scroll back to see the previous interval it simply shows it in view until the next interval takes over. SolutionsThe way I see it there are a few solutions to this problem and subsequently also the day/month cross over issue too. All these solutions should be applied to both the left and right cases. Fill in minor ticksThis solution would fill in the minor ticks as the previous ticks leave the field of view. Only the major interval values would be bolded where the minor ticks would be subdued and fade in and out as needed, max of two visible at a time. A slight variant of this approach could be to keep the interval to the left of the active day to show the previous interval context. In such case the previous interval would be bold and the Arrow to indicate the value is for a previous intervalThis solution would be to add an arrow or carrot icon that would appear when the sticky positioning takes over.
This solution is not ideal for transitioning to a new month because we now run into the same issue with the first of the month sticking to the right of the month grid line. Having two things pointing to the right would be a little much so a variant to this approach would be to push the month label out to the first tick of the next month, not the 1st of the month, with an optional arrow. Then once the first tick of the new month is reached the new month label will stick and the previous left-most month will be wiped away with the new one.
|
Great ideas @nickofthyme I particularly like the first arrow idea, that notify the fact that the Screen.Recording.2023-01-18.at.09.31.20.movShowing the arrow, or "fading" the number linearly as the start-of-week is far away from the current position (similar to your first idea) could be a good solution too |
Yeah that's a big improvement. But the one thing I don't like about this is that the behavior for the first week interval label is now different (i.e. non-sticky between month changes) than other weeks. That was what I was trying to fix with the offset month like this 👇🏼 . That being said, it is a difficult problem to solve and both solutions have pros and cons. Your solution is much cleaner and succinct. |
Yeah the reason for that is that the line you circled there is not sticky, it will scroll past to the left and the
Yeah that's true |
Oh that's not true, September will be pushed by the highlighted line, that represents the beginning of the month. So September will disappear and will stay always at the left of the October label and a line will always separate the two. |
Yeah I think that's correct |
@nickofthyme if I'm not wrong, the solution here is to check whenever the |
I think we keep this issue open to track the changes described in #1934 (comment). These changes would be better for the dynamic timeslip chart with pan and zoom. One variant of this approach could be to provide a different raster layer for labels describing the interval start (i.e. |
@nickofthyme @markov00 as we fixed the main bug we can de prioritize it for now right? Or do we want to move it to 8.10? |
Yes, I updated the project item. I think this task is most impactful for the dynamic timeslip, whenever that starts to be used in kibana we should prioritize this. |
Temporary fix for this suggested in #2536 |
Describe the issue
The current multi-layer time axis has a visible defect when rendering the raster:
startOfWeek
+month + year
raster .In some situations, it can be interpreted that the last start of week of a month is shown as conflicting with the next month label creating a visible confusion when rendering it.
To Reproduce
Steps to reproduce the behavior:
Screenshots
Screen.Recording.2023-01-13.at.19.22.04.mov
Kibana Cross Issues
elastic/kibana#148872
Checklist
:xy
,:partition
):interactions
,:axis
)Kibana Cross Issues
list and thekibana cross issue
tag is appliedThe text was updated successfully, but these errors were encountered: