-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Reclaim chart theme from eui #2069
Comments
@nickofthyme can we close this? |
not yet, there are a few steps more to complete this |
@markov00 cool, do we want to work on them on 8.13? |
@stratoula sounds fine for me |
Sorry @stratoula, Yes after merging elastic/kibana#170914 we can close this. All we need to do after is remove the chart theme logic from eui and eventually remove the deprecated themes from charts down the road. |
@nickofthyme can we complete this before going on with other stuff on 8.14? |
Yup will do! |
Closing with merging elastic/eui#7572 |
Finally removing all theme export from eui in elastic/eui#7682. Finishes this issue in full. |
Per discussions from #865, we have determined to go ahead with moving the charts theme from eui back to charts.
Action items for EUI
Font family
Resolve which font family to use for charts theme? Currently the eui charts theme
defines the
fontFamily
here as...but the eui theme JSON defines three font families as...
I assume for charts we want to use
theme.font.family
, needs confirmation.Export colors
Export computed theme colors here to either the theme JSON or a separate colors-only JSON distributable for dark and light themes.
Action items for charts
Update existing charts theme
Update the charts theme to conform to the current eui chart theme defaults found here. This includes importing the colors and
fontFamily
from eui JSON and/or palette functions. Also need to append the colors withchartLines
andchartBand
defined per theme here.Final logistical steps
Future tasks
Handle dynamic theme changes
Possibly by creating a global charts provider in kibana to update theming based on changes to
EuiProvider
base theming.Migrate away from eui sass
Charts currently relies on several sass files from eui (see
_eui_imports.scss
) to match basic styles from eui. These include variables, functions and mixins.Need to discuss how to resolve this - possible options are:
The text was updated successfully, but these errors were encountered: