Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v61 (main) #170914

Merged
merged 46 commits into from
Dec 13, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 8, 2023

Mend Renovate logo banner

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 60.0.0 -> 61.0.0 age adoption passing confidence

Release Notes

elastic/elastic-charts (@​elastic/charts)

v61.0.0

Compare Source

Bug Fixes
chore
Features
  • metric: allow alpha colors and improve contrast logic (#​2184) (dd5732e)
BREAKING CHANGES
  • BarSeries: now ignores histogram mode in determining stacked series
  • elastic charts theme renamed to LEGACY_DARK_THEME and LEGACY_LIGHT_THEME in favor of the main DARK_THEME and LIGHT_THEME which was merged with eui theme overrides. These new themes are now default.
  • axis: Now respects tickLine.padding whenever tickLine.visible is true

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 8, 2023
@nickofthyme nickofthyme self-assigned this Nov 8, 2023
Copy link
Contributor Author

renovate bot commented Nov 14, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@nickofthyme
Copy link
Contributor

nickofthyme commented Nov 22, 2023

These changes are an effort to merge the eui charts theme with the charts theme to have one consistent chart theme across kibana. The LIGHT_THEME and DARK_THEME from @elastic/charts are now the unified full theme. We will continue to export the original themes as LEGACY_LIGHT_THEME and LEGACY_DARK_THEME, we will update these to the new theme in the future.

The useChartsTheme method/hook on the theme service of the chart plugin is now deprecated, instead you should just assign the baseTheme using the useChartsBaseTheme method/hook. Then simply apply any theme overrides to theme for your specific use case.

return (
   <Chart>
    <Settings
-     theme={[myThemeOverrides, chartsPlugin.theme.useChartsTheme()]}
+     theme={[myThemeOverrides]}
      baseTheme={chartsPlugin.theme.useChartsBaseTheme()}
    />
  ...
  </Chart>
)

These changes should have minimal affect on the look and behavior of your charts but in come cases the overrides used in the theme may cause unexpected changes to the theme. As such we ask that you please verify your chart styles are unaffected by this change. Thanks!

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickofthyme nickofthyme enabled auto-merge (squash) December 12, 2023 15:12
@botelastic botelastic bot added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Dec 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #92 / serverless observability UI Observability Log Explorer Header menu Discover tabs should navigate between discover tabs without keeping the current columns/filters/query/time/data view

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 390.2KB 390.1KB -112.0B
apm 3.7MB 3.7MB +45.0B
cloudSecurityPosture 446.4KB 446.4KB +1.0B
dataVisualizer 618.6KB 618.7KB +162.0B
discover 593.9KB 593.8KB -142.0B
enterpriseSearch 2.7MB 2.7MB -34.0B
expressionGauge 18.8KB 18.7KB -28.0B
expressionHeatmap 27.2KB 26.7KB -522.0B
expressionMetricVis 4.9KB 4.8KB -40.0B
expressionPartitionVis 41.0KB 40.9KB -48.0B
expressionTagcloud 23.2KB 23.2KB +31.0B
expressionXY 132.6KB 132.4KB -156.0B
filesManagement 89.9KB 90.0KB +61.0B
infra 1.9MB 1.9MB -840.0B
lens 1.4MB 1.4MB -142.0B
ml 3.6MB 3.6MB +78.0B
observability 1.1MB 1.1MB -200.0B
profiling 375.6KB 375.6KB +2.0B
securitySolution 13.1MB 13.1MB +190.0B
stackAlerts 80.7KB 80.6KB -29.0B
synthetics 866.6KB 866.5KB -138.0B
threatIntelligence 56.6KB 56.7KB +31.0B
transform 403.9KB 403.9KB +31.0B
triggersActionsUi 1.4MB 1.4MB +62.0B
uptime 480.8KB 480.7KB -162.0B
visTypeTimelion 38.8KB 38.8KB -35.0B
visTypeTimeseries 511.9KB 511.8KB -24.0B
watcher 163.4KB 163.4KB +14.0B
total -1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 36.7KB 36.7KB -65.0B
charts 45.1KB 44.5KB -593.0B
core 375.1KB 375.1KB -36.0B
kbnUiSharedDeps-npmDll 6.2MB 6.2MB +15.0KB
ml 78.6KB 78.6KB -66.0B
observabilityShared 49.5KB 49.4KB -21.0B
synthetics 19.7KB 19.6KB -65.0B
triggersActionsUi 106.1KB 106.2KB +17.0B
uptime 22.9KB 22.9KB -65.0B
total +14.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nickofthyme

@nickofthyme
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.13.0
Projects
None yet