Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-synchronous responsivity to container size #308

Open
2 tasks done
monfera opened this issue Aug 13, 2019 · 2 comments
Open
2 tasks done

Non-synchronous responsivity to container size #308

monfera opened this issue Aug 13, 2019 · 2 comments
Labels
discuss To be discussed :interactions Interactions related issue

Comments

@monfera
Copy link
Contributor

monfera commented Aug 13, 2019

Describe the bug
Upon resize, the elements lag relative to one another, resulting in momentary inconsistent visual state (legend overlapping with data ink) eg. this capture from @cchaos

Screen Capture on 2019-08-12 at 18-12-30

To Reproduce
Steps to reproduce the behavior:

  1. Go to a chart with a legend
  2. Resize horizontally
  3. Observe lack of synchrony in the transition

Expected behavior
Synchronous changes, eg. the chart could be scale-d even while we await a possible new bucketing or axis ticks

Screenshots
If applicable, add screenshots to help explain your problem.

Version (please complete the following information):

  • OS: OS X
  • Browser: current Chrome
  • Elastic Charts: current

Additional context
Add any other context about the problem here.

Errors in browser console
none

Kibana Cross Issues
Has an impact on Lens

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@monfera monfera added bug Something isn't working :interactions Interactions related issue discuss To be discussed labels Aug 13, 2019
@nickofthyme
Copy link
Collaborator

@markov00 This is almost purely a computational efficiency issue I think. Would be interesting to see the improvement of this when the redux changes are in (#281).

@markov00 markov00 removed the bug Something isn't working label Aug 14, 2019
@markov00
Copy link
Member

I've removed the bug label as this was currently designed like that.
We had a small discussion on that during our last sync with some possible solutions:

  • remove the debounce effect on the resize event (can have some drawbacks when resizing multiple charts in a single dashboard)
  • selectively disable the event debounce only for resizing of a single chart, keep it when resizing a whole window
  • try few image scaling fallback: scale on the dom the canvas element and than recompute the chart when the resize event is ended. (the image can also be blurred a bit)
  • fade out the legend when resizing to avoid the legend to overflow the chart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss To be discussed :interactions Interactions related issue
Projects
None yet
Development

No branches or pull requests

3 participants