fix(partition): consider legend extras when computing the legend size #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
bug
markov00
force-pushed
the
2022_02_28-fix_partition_short_legend
branch
from
3df4298
to
43afaae
Compare
nickofthyme
approved these changes
Feb 28, 2022
@nickofthyme see #308 |
nickofthyme
pushed a commit
that referenced
this pull request
Mar 1, 2022
…#1611) * Include the optional extra value to compute the legend items size * Update VRTs
nickofthyme
pushed a commit
that referenced
this pull request
Mar 1, 2022
# [44.0.0](v43.1.1...v44.0.0) (2022-03-01) ### Bug Fixes * **axis:** correct tick alignment in ordinal scale with numeric values ([#1609](#1609)) ([915349d](915349d)) * **legend:** width with duplicate nested pie slice labels ([#1585](#1585)) ([1073231](1073231)) * **partition:** consider legend extras when computing the legend size ([#1611](#1611)) ([2078f3d](2078f3d)) * **xy:** dataIndex keeps original data order on small multiples ([#1597](#1597)) ([9e2566c](9e2566c)) ### Features * **api:** expose Predicate enum ([#1574](#1574)) ([1f73eec](1f73eec)) * **heatmap:** allow rotation of x axis labels ([#1514](#1514)) ([b655156](b655156)) ### BREAKING CHANGES * **heatmap:** `width`, `align`, and `baseline` style properties are removed from the `xAxisLabels` and `yAxisLabels` style of the Heatmap theme. Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To correctly compute the legend size we need to consider multiple aspects:
In the partition chart the third point was missing and it was causing short labels to be wrongly rendered as in this example:
Details
The PR fixes the legend size calculation including the extra formatted value when required.
Issues
fix #1511
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)