-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the color contrast based on the background color #589
Comments
I'm wondering if this issue might be resolved with #608? |
I don't think so, @rshen91 can you test this to see if it happens on master? |
Just to clarify, the idea here is to apply color contrast logic to all the colors, not only text right. So that would include axes lines, tick and labels as well as the series colors themselves? |
Sorry I've missed that reply: |
I believe we should close this as not planned. There will be always something that we can't control or that will override this contrast improvement. |
Describe the bug
The chart is currently rendered on a transparent background. We have two main themes, one for a light background and one for a dark one.
The issue comes out when the user wants to apply a different color to the background: the existing themes are no longer valid in every case for an AA accessibly point of view.
Moreover, the legend is rendered in html that means that it only currently reflect the colors applied through importing the correct CSS method.
A possible solution is:
Theme
js object, including the text color of the legendSettings
prop, this will allow us to tweaks the colors for a better contrast, and also return the current WCAG accessibility level if required.To Reproduce
Steps to reproduce the behavior:
chart
element in the playground cssExpected behavior
The light and dark theme should be revisited as a semantic theme, that applies in all possible cases adapting the colors to the background.
A similar approach should be applied to #238
Screenshots
with light theme:
with dark theme:
Kibana Cross Issues
Checklist
Kibana Cross Issues
listkibana cross issue
tag is associated to the issue if any kibana cross issue is presentThe text was updated successfully, but these errors were encountered: