Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB does not take into account background color for legend styling #60011

Closed
Tracked by #589
timroes opened this issue Mar 12, 2020 · 2 comments · Fixed by #60261
Closed
Tracked by #589

TSVB does not take into account background color for legend styling #60011

timroes opened this issue Mar 12, 2020 · 2 comments · Fixed by #60261
Assignees
@markov00
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) patch-worthy regression Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Mar 12, 2020

While TSVB works perfectly fine in dark mode if your Kibana is set to dark mode, it does not handle individual TSVB background colors that are dark, very well and still uses the dark text on it (e.g. in the legend):

screenshot-20200312-155234

We should use the EUI isDarkColor utility to figure out if the background color is dark and then use the light text themes in elastic chart in those cases.
@timroes timroes added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) regression Team:Visualizations Visualization editors, elastic-charts and infrastructure patch-worthy labels Mar 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor Author

timroes commented Mar 12, 2020

cc @markov00

@timroes timroes changed the title TSVB does not take into account background color for axes styling TSVB does not take into account background color for legend styling Mar 12, 2020
@markov00 markov00 mentioned this issue Mar 17, 2020
Merged
2 tasks
@markov00 markov00 self-assigned this Mar 17, 2020
@markov00 markov00 mentioned this issue Mar 17, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) patch-worthy regression Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] fix text color when using custom background color markov00/kibana
3 participants
@timroes @markov00 @elasticmachine