fix: show crosshairs for external pointer events #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
+ Coverage 74.15% 74.59% +0.44%
==========================================
Files 273 288 +15
Lines 9379 9665 +286
Branches 2029 2072 +43
==========================================
+ Hits 6955 7210 +255
- Misses 2416 2441 +25
- Partials 8 14 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
monfera
changed the title
nickofthyme
changed the title
|
🎉 This PR is included in version 22.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Oct 8, 2020
nickofthyme
added a commit
that referenced
this pull request
Oct 8, 2020
2 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [21.3.0](elastic/elastic-charts@v21.2.0...v21.3.0) (2020-09-16) ### Bug Fixes * legend dark mode hover color ([opensearch-project#820](elastic/elastic-charts#820)) ([d30c21f](elastic/elastic-charts@d30c21f)) ### Features * cancel brush/click event with escape key ([opensearch-project#819](elastic/elastic-charts#819)) ([5a9f21f](elastic/elastic-charts@5a9f21f)) * show crosshair for external pointer events ([opensearch-project#817](elastic/elastic-charts#817)) ([1721514](elastic/elastic-charts@1721514))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #816
Related to elastic/kibana#77306
If a
dispatchExternalPointerEventis used, the crosshairs now show for the respective pointer value.externalPointerEvents.tooltip.visiblenow only controls the tooltip visibility.To disable crosshairs, don't use
dispatchExternalPointerEventat all.Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)