fix: legend dark mode hover color #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
bug
cchaos
previously requested changes
Sep 15, 2020
| @@ -16,7 +16,7 @@ $legendItemVerticalPadding: $echLegendRowGap / 2; | |||
| } | |||
|
|
|||
| &:hover { | |||
There was a problem hiding this comment.
This should actually only get background color on :focus. Leaving the underline as the hover state.
Suggested change
| &:hover { | |
| &:focus { |
There was a problem hiding this comment.
Unfortunately, at the moment we don't have accessible interactions on the legend and thus focus would do nothing. This will be revisited in #580.
Are you ok with it being hover until then?
miukimiu
previously requested changes
Sep 15, 2020
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
nickofthyme
dismissed stale reviews from cchaos and miukimiu
In favor of #820 (review)
|
🎉 This PR is included in version 21.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [21.3.0](elastic/elastic-charts@v21.2.0...v21.3.0) (2020-09-16) ### Bug Fixes * legend dark mode hover color ([opensearch-project#820](elastic/elastic-charts#820)) ([d30c21f](elastic/elastic-charts@d30c21f)) ### Features * cancel brush/click event with escape key ([opensearch-project#819](elastic/elastic-charts#819)) ([5a9f21f](elastic/elastic-charts@5a9f21f)) * show crosshair for external pointer events ([opensearch-project#817](elastic/elastic-charts#817)) ([1721514](elastic/elastic-charts@1721514))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to elastic/kibana#77283
Fixes bad styles for dark theme after changes to legend item hover styles in #749
Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)