Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: legend dark mode hover color #820

Merged
merged 7 commits into from
Sep 15, 2020
Merged

fix: legend dark mode hover color #820

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d72335
fix: legend dark mode hover color
nickofthyme Sep 15, 2020
2689f72
fix: update screenshots from changes
nickofthyme Sep 15, 2020
0f342b7
Merge branch 'master' into fix/legend-color
nickofthyme Sep 15, 2020
211620c
Merge branch 'master' into fix/legend-color
nickofthyme Sep 15, 2020
0d54de7
fix: update legend hover color bg-color
nickofthyme Sep 15, 2020
88825d1
Merge branch 'master' into fix/legend-color
nickofthyme Sep 15, 2020
117ae0c
fix: update screenshots
nickofthyme Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...ies-test-ts-legend-stories-should-render-color-picker-on-mouse-click-1-snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...es-test-ts-legend-stories-should-render-legend-action-on-mouse-hover-1-snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/components/legend/_legend_item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ $legendItemVerticalPadding: $echLegendRowGap / 2;
}

&:hover {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually only get background color on :focus. Leaving the underline as the hover state.

Suggested change
&:hover {
&:focus {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, at the moment we don't have accessible interactions on the legend and thus focus would do nothing. This will be revisited in #580.

Are you ok with it being hover until then?

background-color: #e7f0f7;
background-color: $euiFocusBackgroundColor;
nickofthyme marked this conversation as resolved.
Show resolved Hide resolved
}

&__action {
Expand Down