Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM Dashboard] Hovering on RUM core web vitals percentages showing white background in dark mode #77283

Closed
hendry-lim opened this issue Sep 12, 2020 · 9 comments · Fixed by #78273
Assignees
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@hendry-lim
Copy link

hendry-lim commented Sep 12, 2020

Kibana version: 7.10.0-SNAPSHOT

Elasticsearch version: 7.10.0-SNAPSHOT

Original install method (e.g. download page, yum, from source, etc.): Docker

Describe the bug:
White background color is displayed if hovering on core web vitals percentages in dark mode.
Also applies to the pie chart legends.

Steps to reproduce:

  1. Go to Client Side Monitoring
  2. Mouse over on any of the core web vitals percentages/metrics

Screenshots (if relevant):

Expand

image

@shahzad31 for your review.

@afharo afharo added Feature:ElasticCharts Issues related to the elastic-charts library Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Sep 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Feature:ElasticCharts)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@cchaos cchaos removed Feature:ElasticCharts Issues related to the elastic-charts library Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Sep 14, 2020
@cchaos
Copy link
Contributor

cchaos commented Sep 14, 2020

This actually is a custom data visualization not provided by the Charts team. Tagging in the @elastic/observability-design team.

@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@nickofthyme
Copy link
Contributor

@cchaos This is actually a chart issue.

@nickofthyme
Copy link
Contributor

nickofthyme commented Sep 14, 2020

@cchaos This is coming from changes made to the legend with new legend actions here. I just used the background color used in the mock ups from @miukimiu but couldn't find the color in the eui pallet. Do you know of a suitable color to use from your scss variables for #e7f0f7? Or should I just add it to the chart theme and set it that way?

@nickofthyme nickofthyme added Team:DataVis Team label for DataVis Team and removed Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 14, 2020
@cchaos
Copy link
Contributor

cchaos commented Sep 14, 2020

Ah, I didn't realize this sort of chart exists in Charts, or is it just a simple 1 bar horizontal chart? Anyway, yes this is why using hex values directly is problematic and any colors should always be a EUI SASS var or computation of. EUI has a focus background color that we use for buttons like this called $euiFocusBackgroundColor

@shahzad31
Copy link
Contributor

This is a custom component, it's not using chart legends or bar. I will fix this.

@nickofthyme
Copy link
Contributor

@shahzad31 Oh looks like you are correct, however this raised a similar issue in the charts legend.

@shahzad31 shahzad31 reopened this Sep 16, 2020
@shahzad31 shahzad31 self-assigned this Sep 22, 2020
@shahzad31 shahzad31 added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability and removed Team:DataVis Team label for DataVis Team labels Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants