-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change between 21.1.0 and 21.3.2 #830
Comments
@timroes you are correct this was caused by #810, from the changes below as of - value: tickFormatter(value, tickFormatOptions),
+ value,
+ formattedValue: tickFormatter(value, tickFormatOptions), That is entirely my fault, I should have seen that and kept the value as formatted with a new Do you think I should deprecate all prior versions and make a new major release? Breaking versions: |
I think that's the only 'clean' way to fix that |
# [22.0.0](v21.3.2...v22.0.0) (2020-09-22) ### Bug Fixes * breaking change in patch release of 21.1.1 ([d0ddc45](d0ddc45)), closes [#810](#810) ### BREAKING CHANGES * caused by changes in #810 see #830 for more info * `TooltipValue.value` is now raw value and `TooltipValue.formattedValue` is now the string formatted value.
Fixed by d0ddc45 |
Updated release logs to indicate version deprecations and updated release notes for |
breaking change caused by changes in elastic#810 see elastic#830 for more info BREAKING CHANGE: `TooltipValue.value` is now raw value and `TooltipValue.formattedValue` is now the string formatted value. fix elastic#810
There has been an actual breaking change in API between those versions. Earlier the
props
passed into acustomTooltip
component in the setting would haveprops.values[0].value
being the formatted string, now it's the raw value and.formattedValue
is the formatted string. The behavior of course makes imho more sense that way, but it was nevertheless an API breakage.It could have been caused by #810, but it could also be linked together with some other PRs, that touched tooltip, and this one was just the one introducing
.formattedValue
.cc @markov00
The text was updated successfully, but these errors were encountered: