Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart legend circle elements fail accessibility test as all have identical id #970

Closed
peteharverson opened this issue Jan 12, 2021 · 4 comments · Fixed by #971
Closed

Chart legend circle elements fail accessibility test as all have identical id #970

peteharverson opened this issue Jan 12, 2021 · 4 comments · Fixed by #971
Assignees
Labels
:accessibility Accessibility related issue bug Something isn't working :chart Chart element related issue :legend Legend related issue released Issue released publicly

Comments

@peteharverson
Copy link

The circle elements used in chart legends all use the identical id of dot-a, which causes an accessibility issue, as revealed by the axe web accessibility testing tool.

Can be seen on https://elastic.github.io/elastic-charts/?path=/story/legend--right, or for example:

image

This will block accessibility tests being added for elastic/kibana#51456 on any pages which use an Elastic chart where the legend is visible.

@peteharverson peteharverson added bug Something isn't working :chart Chart element related issue :legend Legend related issue :accessibility Accessibility related issue labels Jan 12, 2021
@nickofthyme
Copy link
Collaborator

Thanks @peteharverson we'll fix that ASAP.

@darnautov
Copy link
Contributor

hey! 👋 Not sure if #971 fix suffices, because it's possible to have multiple charts with the same legend on the same page. Prepending a unique chart id to the id attribute should work. cc @rshen91 @nickofthyme

@rshen91
Copy link
Contributor

rshen91 commented Jan 13, 2021

@darnautov good call - there is a new PR without any id (no longer needed) that should address this issue - #973

@markov00
Copy link
Member

🎉 This issue has been resolved in version 24.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:accessibility Accessibility related issue bug Something isn't working :chart Chart element related issue :legend Legend related issue released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants