-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(partitions): Small multiples legends #1094
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've few doubts on what was changed here:
https://github.com/elastic/elastic-charts/blob/9aa1d202b6ccc55dc3169f2a100a3b9ba3943761/integration/tests/__image_snapshots__/legend-stories-test-ts-legend-stories-should-have-the-same-order-as-nested-with-no-indent-even-if-there-are-repeated-labels-1-snap.png
I've added the legendStrategy to that story and it looks a bit wrong: it doesn't work correctly with all the strategies. Is that a wanted behaviour?
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
=======================================
Coverage 71.71% 71.71%
=======================================
Files 383 381 -2
Lines 11924 11918 -6
Branches 2590 2598 +8
=======================================
- Hits 8551 8547 -4
+ Misses 3342 3340 -2
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, agreed on the new partition flat legend alphabetical order.
Lens uses the flat version with only the root layer or the hierarchical version with all layers.
# [27.0.0](v26.1.0...v27.0.0) (2021-03-31) ### Features * **partitions:** Small multiples legends ([#1094](#1094)) ([c39d113](c39d113)) ### BREAKING CHANGES * **partitions:** the `flatLegend` (true) option yields alphabetical, formatted name based sorting for unique name/color occurrences, to make it easy for the user to look up names in the legend as it's alphabetically sorted
🎉 This PR is included in version 27.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [27.0.0](elastic/elastic-charts@v26.1.0...v27.0.0) (2021-03-31) ### Features * **partitions:** Small multiples legends ([opensearch-project#1094](elastic/elastic-charts#1094)) ([02e45d6](elastic/elastic-charts@02e45d6)) ### BREAKING CHANGES * **partitions:** the `flatLegend` (true) option yields alphabetical, formatted name based sorting for unique name/color occurrences, to make it easy for the user to look up names in the legend as it's alphabetically sorted
Summary
Flat legends (now sorted alphabetically; cursor hovering over Minerals - green - to highlight):
Hierarchical legends:
Checklist
Delete any items that are not applicable to this PR.