test: don't import jsdom in node environment #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 37.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently introduced a small change on the dependencies in our jest tests #1367
After merging that PR, the Jenkins CI was suffering from a missing C++ library, used by the
canvaspackage, updated in the mentioned PR.The issue was that the
canvaspackage doesn't need to be called in the VRT environment, but just in the uni test one.I've discovered that the
canvaspackage is only requested when using ajsdomenvironment in jest, but the current VRT tests runs in anodeenvironment instead.I've finally found the root cause: a JSDOM import, in
page_objects/common.tsthat causes thecanvaslib to be requested and resolved in the jestnodeenvironment.I've removed both the import and the unused function that was using that import.