Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove obsolete configurations #1803

Merged
merged 7 commits into from
Aug 30, 2022

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Aug 29, 2022

Summary

Remove obsolete configurations after buildkite migration.

Details

Changes include:

  • Removes .ci/ with jenkins configs
  • Removes .github/ actions and workflow. Excludes only release.yml to be migrated to buildkite.
  • Removes integration/
  • Corrects all usages of integration/ throughout the code and change to new e2e usage.
  • Updates testing.md to reflect latest VRT usages

Issues

#1617

@nickofthyme nickofthyme added :docs Anything related to documentation, API, storybook visual testing issues related to visual testing :ci :build Build tools / dependencies internal Internal changes with no external impact labels Aug 29, 2022
@nickofthyme nickofthyme mentioned this pull request Aug 29, 2022
10 tasks
@nickofthyme
Copy link
Collaborator Author

buildkite update vrt

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove also every dependencies on puppeteer we have?
like:

"jest-puppeteer": "6.1.1",
"jest-puppeteer-docker": "^1.4.2",
 "puppeteer": "^5.5.0",
"@types/expect-puppeteer": "^4.4.5",
"@types/jest-environment-puppeteer": "^5.0.2",
 "@types/puppeteer": "^5.4.2",

And probably anything related to jest-image-snapshot

@nickofthyme
Copy link
Collaborator Author

buildkite test this

Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this big cleanup!

@nickofthyme nickofthyme merged commit 8308468 into elastic:master Aug 30, 2022
@nickofthyme nickofthyme deleted the remove-obsolete-ci-code branch August 30, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:build Build tools / dependencies :ci :docs Anything related to documentation, API, storybook internal Internal changes with no external impact visual testing issues related to visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants