Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: enable noUncheckedIndexedAccess #2006

Merged
merged 40 commits into from
Apr 18, 2023
Merged

chore!: enable noUncheckedIndexedAccess #2006

merged 40 commits into from
Apr 18, 2023

Commits on Mar 23, 2023

  1. chore: enable noUncheckedIndexedAccess in src

    @nickofthyme
    nickofthyme committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a01740d View commit details
    Browse the repository at this point in the history

  2. fix: errors in partition chart

    @nickofthyme
    nickofthyme committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    6a7e411 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. refactor: remove getSpecOrNull in favor of getSpecFromStore 

    - getSpecFromStore option to require spec or throw
- getSpecFromStore option to optionally get spec or null
    @nickofthyme
    nickofthyme committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    d31dfbb View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. fix: type errors in src/ from stricter config

    @nickofthyme
    nickofthyme committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    8caf569 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. fix: defined numerical value assertion

    @nickofthyme
    nickofthyme committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    b8bd8f4 View commit details
    Browse the repository at this point in the history

  2. fix: x domain logical error

    @nickofthyme
    nickofthyme committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    025a0d3 View commit details
    Browse the repository at this point in the history

  3. fix: bad abstraction of index access

    @nickofthyme
    nickofthyme committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    cac4aa0 View commit details
    Browse the repository at this point in the history

  4. fix: parition link text logic

    @nickofthyme
    nickofthyme committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f7ebb6e View commit details
    Browse the repository at this point in the history

  5. fix: heatmap label wrap truncation logic

    @nickofthyme
    nickofthyme committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    39db842 View commit details
    Browse the repository at this point in the history

  6. chore: update api

    @nickofthyme
    nickofthyme committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    08f53cd View commit details
    Browse the repository at this point in the history

  7. fix: treemap node access logic error

    @nickofthyme
    nickofthyme committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    ee85f1c View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. chore: update tsconfig structure for src 

    Newer versions of typescript/vscode now support multiple tsconfig.json
files in a single project. Previously the base tsconfig.json was the only
file used and all others were ignored. Now if a tsconfig.json file is at
the root of a directory that will be applied to all child directories.
This change was causing failures in cli but not is vscode for test files.
    @nickofthyme
    nickofthyme committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    2648f52 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. refactor: datasets to use key access over index 

    This index access makes it easier to type and describe the different variants
This is required as a limitation of typescript/vscode not permitting nested tsconfigs
    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    74c9965 View commit details
    Browse the repository at this point in the history

  2. docs: fix remaining storybook type errors 

    here we favor the use of forced unwrapping (i.e. `d[0]!`) for less strict checking
    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d2690e9 View commit details
    Browse the repository at this point in the history

  3. test: update data type on test datasets

    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    82ddc9e View commit details
    Browse the repository at this point in the history

  4. chore: improve domain typing in continuous scale class

    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    9d40f43 View commit details
    Browse the repository at this point in the history

  5. test: fix all type errors related to new config option 

    here we favor the use of forced unwrapping (i.e. `d[0]!`) for less strict checking
    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ac7f31b View commit details
    Browse the repository at this point in the history

  6. chore: fix type errors in github_bot 

    - better type guards
- move base tsconfig to not conflict with top level
- update dockerfile with file changes
    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2a657a4 View commit details
    Browse the repository at this point in the history

  7. chore: fix type errors on e2e files, add type guards

    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b3da5e6 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into enable-no-unchecked-access

    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c46731c View commit details
    Browse the repository at this point in the history

  9. chore: fix api tsconfig locations

    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8f813f4 View commit details
    Browse the repository at this point in the history

  10. fix: lint errors after typing sample data as [number, number]

    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    007fa17 View commit details
    Browse the repository at this point in the history

  11. fix: storybook type errors

    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3af073c View commit details
    Browse the repository at this point in the history

  12. ci: remove dev console logs from ci exec

    @nickofthyme
    nickofthyme committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1615944 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Merge branch 'main' into enable-no-unchecked-access

    @nickofthyme
    nickofthyme committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    991bb22 View commit details
    Browse the repository at this point in the history

  2. refactor(gauge): fix index check with better type

    @markov00
    markov00 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    5ccdc34 View commit details
    Browse the repository at this point in the history

  3. refactor(heatmap): fix index check with better type

    @markov00
    markov00 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    1da7ab9 View commit details
    Browse the repository at this point in the history

  4. refactor: invert negative check

    @markov00
    markov00 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    db3695f View commit details
    Browse the repository at this point in the history

  5. fix: no line to origin

    @markov00
    markov00 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    e04142d View commit details
    Browse the repository at this point in the history

  6. refactor: fix continuous domain type

    @markov00
    markov00 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    8759520 View commit details
    Browse the repository at this point in the history

  7. refactor: scale band range to [number,number]

    @markov00
    markov00 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    f45ce0f View commit details
    Browse the repository at this point in the history

  8. refactor: replace for continue with for of loop

    @markov00
    markov00 committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    3525921 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. chore: separate storybook tsconfig setup

    @nickofthyme
    nickofthyme committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    729cba2 View commit details
    Browse the repository at this point in the history

  2. revert: storybook type changes

    @nickofthyme
    nickofthyme committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    0bfd310 View commit details
    Browse the repository at this point in the history

  3. chore: reduce goal story code duplication

    @nickofthyme
    nickofthyme committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    af1116a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/enable-no-unchecked-access' into… 

    … enable-no-unchecked-access
    @nickofthyme
    nickofthyme committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    c897eba View commit details
    Browse the repository at this point in the history

  5. chore(flame): check hoverValue before applying format

    @nickofthyme
    nickofthyme committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    55c7c49 View commit details
    Browse the repository at this point in the history

  6. chore: apply suggestion for findRange util 

    Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
    @nickofthyme @markov00
    nickofthyme and markov00 authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ede6b9a View commit details
    Browse the repository at this point in the history

  7. chore: update tsconfig to exclude playground

    @nickofthyme
    nickofthyme committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    6062e90 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/enable-no-unchecked-access' into… 

    … enable-no-unchecked-access
    @nickofthyme
    nickofthyme committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ad0a0c3 View commit details
    Browse the repository at this point in the history