-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legend): add keyboard navigation #880
Merged
Merged
Changes from 46 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
8846dd2
feat: add tabbing into legend
rshen91 3f66d55
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 b85af45
feat: add focus to navigation of legend
rshen91 5342cc8
style: fixing echLegendLlistContainer orientation
rshen91 5bfd8ab
fix: remove outer button fixing style issues
rshen91 7ded2df
test: update unit tests
rshen91 f783dba
fix: improve navigation for action story
rshen91 16fcfa7
feat: add screen reader for extra
rshen91 d0d4a2e
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 c4b60e1
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 cfd84a6
fix: change aria label and unit test snapshots
rshen91 8bafadd
test: update vrts
rshen91 09c1048
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 69c528f
refactor: add some cleanup
rshen91 835655f
test: revert vrt updates
rshen91 4637ccc
feat: initial review changes
rshen91 f7e2f27
test: update unit tests legend
rshen91 ec97027
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 5b842fe
style: fix focus styling
rshen91 7753767
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 bc14508
fix: add color name to aria label
rshen91 038f30c
fix: cleanup style and test
rshen91 e5a83e4
fix: add ownFocus to color story
rshen91 dc373e8
fix: add changes to label for isSeriesHidden
rshen91 cde7eb9
fix: add label to aria label
rshen91 07eadda
fix: add clearer aria label to color picker
rshen91 c78bfce
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 f751a99
style: incorporate style changes in review
rshen91 e2f516a
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 ef51a44
WIP
rshen91 a2cfae8
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 a85b704
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 5e29295
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 35425e2
test: add puppeteer test for aria label and tabbing on legend items
rshen91 0538d65
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 27c4826
test: add async test for tab and enter
rshen91 58a74d4
test: update vrts
rshen91 326cc37
refactor: update async test
rshen91 07fd6e2
test: add style changes and revert vrts
rshen91 92eb0e2
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 ecc7797
feat: update aria label for isSeriesHidden
rshen91 48f01e7
test: euiring styling vrt update on tests
rshen91 fc8c562
test: flaky test update and second wait for legend test
rshen91 dd19e9d
test: update vrts
rshen91 d14a03a
test: add style consistency to test
rshen91 03ee240
test: add style test for pupeteer
rshen91 c260426
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 3631426
test: add disable-animations to common and area stories
rshen91 64e99f8
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 02a2555
test: add missing area vrts
rshen91 5bdb611
refactor: remove url parameter from disableAnimations
rshen91 8932129
Merge remote-tracking branch 'upstream/master' into legend-keyboard
rshen91 55f1628
style: remove old comments
rshen91 02a06fe
style: disable eslint in lines vs entire file
rshen91 a5acd93
refactor: pr feedback changes
rshen91 547f69d
Merge branch 'master' into legend-keyboard
rshen91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
@import '../node_modules/@elastic/eui/src/theme_light.scss'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doesn't look like you are using this file There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed in a5acd93 |
||
|
||
html { | ||
background-color: white; | ||
} | ||
|
||
.story-chart { | ||
box-sizing: border-box; | ||
background: white; | ||
} | ||
|
||
.story-chart-dark { | ||
box-sizing: border-box; | ||
background: #1a1b20; | ||
} | ||
|
||
.echInvisible { | ||
visibility: hidden; | ||
} | ||
|
||
#story-root { | ||
padding: 20px; | ||
width: 100%; | ||
height: 400px; | ||
position: relative; | ||
box-sizing: border-box; | ||
background-color: blanchedalmond; | ||
|
||
*, | ||
*::after, | ||
*::before, | ||
.echLegendItem { | ||
transition-delay: 0s !important; | ||
transition-duration: 0s !important; | ||
animation-delay: -0.0001s !important; | ||
animation-duration: 0s !important; | ||
animation-play-state: paused !important; | ||
caret-color: transparent !important; | ||
} | ||
} | ||
|
||
#story-root + div table { | ||
border: 1px solid gray; | ||
} | ||
|
||
#story-root + div table th { | ||
border: 1px solid gray; | ||
padding: 5px; | ||
} | ||
|
||
#story-root + div table td { | ||
border: 1px solid gray; | ||
padding: 5px; | ||
} | ||
|
||
.Pane.vertical.Pane1 { | ||
background: red; | ||
} | ||
|
||
html.echVisualTesting { | ||
background-color: blanchedalmond; | ||
|
||
#root > div:not(#story-root) { | ||
display: none; | ||
} | ||
|
||
#root { | ||
padding-top: 200px; | ||
padding-bottom: 200px; | ||
} | ||
} | ||
|
||
// for using EuiWrappingPopover in stories | ||
.euiPopover__anchor { | ||
width: 100%; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By adding the class you can then do...