Fix crashes and ugly error logs on unsupported systems for UP integration #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
changed the title
jackshirazi
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #299, improves the handling of #228.
This PR adds explicit MUSL-linux detection so that we don't just crash the JVM on such distros (e.g. alpine).
In addition, the behaviour of the UP-integration has been refined so that the
enabledoption defaults tofalseon unsupported systems, so that we don't end up with ugly error logs by default on e.g. windows and alpine.If the
enabledoptions is explicitly configured totrueorauto, error logs will show up but the agent will still start correctly.I've manually tested the behaviour with an alpine container.