Added portable musl build for jvmti-library #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
reviewed
Jul 10, 2024
SylvainJuge
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
With the 0.3.2 agent I used to get the following error when starting the agent with eclipse-temurin:17-alpine Docker image to run the agent with cpu-burner app.
otel.javaagent 2024-07-10 15:16:10:988 +0000] [main] ERROR co.elastic.otel.JvmtiAccess - Failed to load jvmti native library
java.lang.UnsatisfiedLinkError: /tmp/elastic-jvmti-linux-x64-4813494d137e1631bba301d5acab6e7b-6ca4b5b2f9e60ed3ef1c59643b609af0.so: Error loading shared library ld-linux-x86-64.so.2: No such file or directory (needed by /tmp/elastic-jvmti-linux-x64-4813494d137e1631bba301d5acab6e7b-6ca4b5b2f9e60ed3ef1c59643b609af0.so)
at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)
at java.base/jdk.internal.loader.NativeLibraries$NativeLibraryImpl.open(NativeLibraries.java:388)
Re-building this PR locally and using this updated agent, the agent now starts as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228 , but needs some more investigation:
It looks like the UP integration is partly broken on musl. The profiling data will contain the service name, but the trace/span-id correlation seems to not work.