Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump opentelemetryJavaagent from 1.32.0 to 2.0.0 #96

Merged
merged 10 commits into from
Feb 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 25, 2024

Bumps opentelemetryJavaagent from 1.32.0 to 2.0.0.
Updates io.opentelemetry.javaagent:opentelemetry-javaagent from 1.32.0 to 2.0.0

Release notes

Sourced from io.opentelemetry.javaagent:opentelemetry-javaagent's releases.

Version 2.0.0

This release targets the OpenTelemetry SDK 1.34.1.

Note that many artifacts have the -alpha suffix attached to their version number, reflecting that they are still alpha quality and will continue to have breaking changes. Please see the VERSIONING.md for more details.

The 2.0.0 release contains significant breaking changes that will most likely affect all users, please be sure to read the breaking changes below carefully.

Note: 1.32.x will be security patched for at least 6 months in case some of the changes below are too disruptive to adopt right away.

⚠️⚠️ Breaking changes ⚠️⚠️

  • The default OTLP protocol has been changed from grpc to http/protobuf in order to align with the specification. You can switch to the grpc protocol using OTEL_EXPORTER_OTLP_PROTOCOL=grpc or -Dotel.exporter.otlp.protocol=grpc.
  • Micrometer metric bridge has been disabled by default. You can enable it using OTEL_INSTRUMENTATION_MICROMETER_ENABLED=true or -Dotel.instrumentation.micrometer.enabled=true.
  • The OTLP logs exporter is now enabled by default. You can disable it using OTEL_LOGS_EXPORTER=none or -Dotel.logs.exporter=none.
  • Controller spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true.
  • View spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_VIEW_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.view-telemetry.enabled=true.
  • ⚠️⚠️ Stable HTTP semantic conventions are now emitted ⚠️⚠️ - TOO MANY CHANGES TO LIST HERE, be sure to review the full list of changes.
  • Stable JVM semantic conventions are now emitted. - Memory metrics - process.runtime.jvm.memory.usage renamed to jvm.memory.used - process.runtime.jvm.memory.committed renamed to jvm.memory.committed - process.runtime.jvm.memory.limit renamed to jvm.memory.limit - process.runtime.jvm.memory.usage_after_last_gc renamed to jvm.memory.used_after_last_gc - process.runtime.jvm.memory.init renamed to jvm.memory.init (still experimental) - Metric attributes - type renamed to jvm.memory.type - pool renamed to jvm.memory.pool.name - Garbage collection metrics - process.runtime.jvm.gc.duration renamed to jvm.gc.duration - Metric attributes - name renamed to jvm.gc.name - action renamed to jvm.gc.action - Thread metrics - process.runtime.jvm.threads.count renamed to jvm.threads.count - Metric attributes - daemon renamed to jvm.thread.daemon - Classes metrics - process.runtime.jvm.classes.loaded renamed to jvm.classes.loaded - process.runtime.jvm.classes.unloaded renamed to jvm.classes.unloaded - process.runtime.jvm.classes.current_loaded renamed to jvm.classes.count - CPU metrics - process.runtime.jvm.cpu.utilization renamed to jvm.cpu.recent_utilization - process.runtime.jvm.system.cpu.load_1m renamed to jvm.system.cpu.load_1m (still experimental) - process.runtime.jvm.system.cpu.utilization renamed to jvm.system.cpu.utilization (still experimental) - Buffer metrics - process.runtime.jvm.buffer.limit renamed to jvm.buffer.memory.limit (still experimental) - process.runtime.jvm.buffer.count renamed to jvm.buffer.count (still experimental) - process.runtime.jvm.buffer.usage renamed to jvm.buffer.memory.usage (still experimental) - Metric attributes - pool renamed to jvm.buffer.pool.name

More migration notes

  • Lettuce CONNECT spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_LETTUCE_CONNECTION_TELEMETRY_ENABLED=true or -Dotel.instrumentation.lettuce.connection-telemetry.enabled=true.
  • The configuration property otel.instrumentation.log4j-appender.experimental.capture-context-data-attributes has been renamed to otel.instrumentation.log4j-appender.experimental.capture-mdc-attributes.
  • MDC attribute prefixes (log4j.mdc. and logback.mdc.*) have been removed.
  • The artifact instrumentation-api-semconv has been renamed to instrumentation-api-incubator.
  • HTTP classes have been moved from instrumentation-api-incubator to instrumentation-api and as a result are now stable.

🌟 New javaagent instrumentation

  • Vert.x redis client (#9838)

📈 Enhancements

  • Reduce reactor stack trace depth (#9923)
  • Implement error.type in spring-webflux and reactor-netty instrumentations (#9967)
  • Bridge metric advice in OpenTelemetry API 1.32 (#10026)
  • Capture http.route for akka-http (#10039)
  • Rename telemetry.auto.version to telemetry.distro.version and add telemetry.distro.name (#9065)
  • Implement forEach support for aws sqs tracing list (#10062)
  • Add http client response attributes to aws sqs process spans (#10074)
  • Add support for OTEL_RESOURCE_ATTRIBUTES, OTEL_SERVICE_NAME, OTEL_EXPORTER_OTLP_HEADERS, and OTEL_EXPORTER_OTLP_PROTOCOL for spring boot starter (#9950)
  • Add elasticsearch-api-client as instrumentation name to elasticsearch-api-client-7.16 (#10102)
  • Add instrumentation for druid connection pool (#9935)
  • Remove deprecated rocketmq setting (#10125)
  • JMX metrics for Tomcat with 'Tomcat' JMX domain (#10115)
  • Capture the SNS topic ARN under the 'messaging.destination.name' span attribute. (#10096)
  • Add network attributes to rabbitmq process spans (#10210)
  • Add UserExcludedClassloadersConfigurer (#10134)
  • Apply both server attributes & network attributes to Lettuce 5.1 (#10197)

... (truncated)

Changelog

Sourced from io.opentelemetry.javaagent:opentelemetry-javaagent's changelog.

Version 2.0.0 (2024-01-12)

The 2.0.0 release contains significant breaking changes that will most likely affect all users, please be sure to read the breaking changes below carefully.

Note: 1.32.x will be security patched for at least 6 months in case some of the changes below are too disruptive to adopt right away.

⚠️⚠️ Breaking changes ⚠️⚠️

  • The default OTLP protocol has been changed from grpc to http/protobuf in order to align with the specification. You can switch to the grpc protocol using OTEL_EXPORTER_OTLP_PROTOCOL=grpc or -Dotel.exporter.otlp.protocol=grpc.
  • Micrometer metric bridge has been disabled by default. You can enable it using OTEL_INSTRUMENTATION_MICROMETER_ENABLED=true or -Dotel.instrumentation.micrometer.enabled=true.
  • The OTLP logs exporter is now enabled by default. You can disable it using OTEL_LOGS_EXPORTER=none or -Dotel.logs.exporter=none.
  • Controller spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true.
  • View spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_VIEW_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.view-telemetry.enabled=true.
  • ⚠️⚠️ Stable HTTP semantic conventions are now emitted ⚠️⚠️
    • TOO MANY CHANGES TO LIST HERE, be sure to review the full list of changes.
  • Stable JVM semantic conventions are now emitted.
    • Memory metrics
      • process.runtime.jvm.memory.usage renamed to jvm.memory.used
      • process.runtime.jvm.memory.committed renamed to jvm.memory.committed
      • process.runtime.jvm.memory.limit renamed to jvm.memory.limit
      • process.runtime.jvm.memory.usage_after_last_gc renamed to jvm.memory.used_after_last_gc
      • process.runtime.jvm.memory.init renamed to jvm.memory.init (still experimental)
      • Metric attributes
        • type renamed to jvm.memory.type
        • pool renamed to jvm.memory.pool.name
    • Garbage collection metrics
      • process.runtime.jvm.gc.duration renamed to jvm.gc.duration
      • Metric attributes
        • name renamed to jvm.gc.name
        • action renamed to jvm.gc.action
    • Thread metrics
      • process.runtime.jvm.threads.count renamed to jvm.threads.count
      • Metric attributes
        • daemon renamed to jvm.thread.daemon
    • Classes metrics
      • process.runtime.jvm.classes.loaded renamed to jvm.classes.loaded
      • process.runtime.jvm.classes.unloaded renamed to jvm.classes.unloaded

... (truncated)

Commits
  • 39e7e9c [release/v2.0.x] Prepare release 2.0.0 (#10228)
  • 8141b20 Change log for 2.0.0 (#10177)
  • f1ed419 Disable lettuce CONNECT spans by default (#10215)
  • c418b14 Don't append signal path to signal specific endpoint (#10214)
  • 6fde05d chore(deps): update plugin org.gradle.toolchains.foojay-resolver-convention t...
  • 36ed203 Apply both serverAttributes & networkAttributes to Lettuce 5.1 (#10197)
  • e843d08 fix(deps): update dependency io.r2dbc:r2dbc-proxy to v1.1.4.release (#10218)
  • b5fd786 fix(deps): update dependency io.grpc:grpc-bom to v1.61.0 (#10220)
  • 3948204 Update the OpenTelemetry SDK version to 1.34.1 (#10217)
  • 32ea07c Change Spring starter default otlp protocol from gRPC to http/protobuf (#10212)
  • Additional commits viewable in compare view

Updates io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom from 1.32.0 to 2.0.0

Release notes

Sourced from io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom's releases.

Version 2.0.0

This release targets the OpenTelemetry SDK 1.34.1.

Note that many artifacts have the -alpha suffix attached to their version number, reflecting that they are still alpha quality and will continue to have breaking changes. Please see the VERSIONING.md for more details.

The 2.0.0 release contains significant breaking changes that will most likely affect all users, please be sure to read the breaking changes below carefully.

Note: 1.32.x will be security patched for at least 6 months in case some of the changes below are too disruptive to adopt right away.

⚠️⚠️ Breaking changes ⚠️⚠️

  • The default OTLP protocol has been changed from grpc to http/protobuf in order to align with the specification. You can switch to the grpc protocol using OTEL_EXPORTER_OTLP_PROTOCOL=grpc or -Dotel.exporter.otlp.protocol=grpc.
  • Micrometer metric bridge has been disabled by default. You can enable it using OTEL_INSTRUMENTATION_MICROMETER_ENABLED=true or -Dotel.instrumentation.micrometer.enabled=true.
  • The OTLP logs exporter is now enabled by default. You can disable it using OTEL_LOGS_EXPORTER=none or -Dotel.logs.exporter=none.
  • Controller spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true.
  • View spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_VIEW_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.view-telemetry.enabled=true.
  • ⚠️⚠️ Stable HTTP semantic conventions are now emitted ⚠️⚠️ - TOO MANY CHANGES TO LIST HERE, be sure to review the full list of changes.
  • Stable JVM semantic conventions are now emitted. - Memory metrics - process.runtime.jvm.memory.usage renamed to jvm.memory.used - process.runtime.jvm.memory.committed renamed to jvm.memory.committed - process.runtime.jvm.memory.limit renamed to jvm.memory.limit - process.runtime.jvm.memory.usage_after_last_gc renamed to jvm.memory.used_after_last_gc - process.runtime.jvm.memory.init renamed to jvm.memory.init (still experimental) - Metric attributes - type renamed to jvm.memory.type - pool renamed to jvm.memory.pool.name - Garbage collection metrics - process.runtime.jvm.gc.duration renamed to jvm.gc.duration - Metric attributes - name renamed to jvm.gc.name - action renamed to jvm.gc.action - Thread metrics - process.runtime.jvm.threads.count renamed to jvm.threads.count - Metric attributes - daemon renamed to jvm.thread.daemon - Classes metrics - process.runtime.jvm.classes.loaded renamed to jvm.classes.loaded - process.runtime.jvm.classes.unloaded renamed to jvm.classes.unloaded - process.runtime.jvm.classes.current_loaded renamed to jvm.classes.count - CPU metrics - process.runtime.jvm.cpu.utilization renamed to jvm.cpu.recent_utilization - process.runtime.jvm.system.cpu.load_1m renamed to jvm.system.cpu.load_1m (still experimental) - process.runtime.jvm.system.cpu.utilization renamed to jvm.system.cpu.utilization (still experimental) - Buffer metrics - process.runtime.jvm.buffer.limit renamed to jvm.buffer.memory.limit (still experimental) - process.runtime.jvm.buffer.count renamed to jvm.buffer.count (still experimental) - process.runtime.jvm.buffer.usage renamed to jvm.buffer.memory.usage (still experimental) - Metric attributes - pool renamed to jvm.buffer.pool.name

More migration notes

  • Lettuce CONNECT spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_LETTUCE_CONNECTION_TELEMETRY_ENABLED=true or -Dotel.instrumentation.lettuce.connection-telemetry.enabled=true.
  • The configuration property otel.instrumentation.log4j-appender.experimental.capture-context-data-attributes has been renamed to otel.instrumentation.log4j-appender.experimental.capture-mdc-attributes.
  • MDC attribute prefixes (log4j.mdc. and logback.mdc.*) have been removed.
  • The artifact instrumentation-api-semconv has been renamed to instrumentation-api-incubator.
  • HTTP classes have been moved from instrumentation-api-incubator to instrumentation-api and as a result are now stable.

🌟 New javaagent instrumentation

  • Vert.x redis client (#9838)

📈 Enhancements

  • Reduce reactor stack trace depth (#9923)
  • Implement error.type in spring-webflux and reactor-netty instrumentations (#9967)
  • Bridge metric advice in OpenTelemetry API 1.32 (#10026)
  • Capture http.route for akka-http (#10039)
  • Rename telemetry.auto.version to telemetry.distro.version and add telemetry.distro.name (#9065)
  • Implement forEach support for aws sqs tracing list (#10062)
  • Add http client response attributes to aws sqs process spans (#10074)
  • Add support for OTEL_RESOURCE_ATTRIBUTES, OTEL_SERVICE_NAME, OTEL_EXPORTER_OTLP_HEADERS, and OTEL_EXPORTER_OTLP_PROTOCOL for spring boot starter (#9950)
  • Add elasticsearch-api-client as instrumentation name to elasticsearch-api-client-7.16 (#10102)
  • Add instrumentation for druid connection pool (#9935)
  • Remove deprecated rocketmq setting (#10125)
  • JMX metrics for Tomcat with 'Tomcat' JMX domain (#10115)
  • Capture the SNS topic ARN under the 'messaging.destination.name' span attribute. (#10096)
  • Add network attributes to rabbitmq process spans (#10210)
  • Add UserExcludedClassloadersConfigurer (#10134)
  • Apply both server attributes & network attributes to Lettuce 5.1 (#10197)

... (truncated)

Changelog

Sourced from io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom's changelog.

Version 2.0.0 (2024-01-12)

The 2.0.0 release contains significant breaking changes that will most likely affect all users, please be sure to read the breaking changes below carefully.

Note: 1.32.x will be security patched for at least 6 months in case some of the changes below are too disruptive to adopt right away.

⚠️⚠️ Breaking changes ⚠️⚠️

  • The default OTLP protocol has been changed from grpc to http/protobuf in order to align with the specification. You can switch to the grpc protocol using OTEL_EXPORTER_OTLP_PROTOCOL=grpc or -Dotel.exporter.otlp.protocol=grpc.
  • Micrometer metric bridge has been disabled by default. You can enable it using OTEL_INSTRUMENTATION_MICROMETER_ENABLED=true or -Dotel.instrumentation.micrometer.enabled=true.
  • The OTLP logs exporter is now enabled by default. You can disable it using OTEL_LOGS_EXPORTER=none or -Dotel.logs.exporter=none.
  • Controller spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true.
  • View spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_VIEW_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.view-telemetry.enabled=true.
  • ⚠️⚠️ Stable HTTP semantic conventions are now emitted ⚠️⚠️
    • TOO MANY CHANGES TO LIST HERE, be sure to review the full list of changes.
  • Stable JVM semantic conventions are now emitted.
    • Memory metrics
      • process.runtime.jvm.memory.usage renamed to jvm.memory.used
      • process.runtime.jvm.memory.committed renamed to jvm.memory.committed
      • process.runtime.jvm.memory.limit renamed to jvm.memory.limit
      • process.runtime.jvm.memory.usage_after_last_gc renamed to jvm.memory.used_after_last_gc
      • process.runtime.jvm.memory.init renamed to jvm.memory.init (still experimental)
      • Metric attributes
        • type renamed to jvm.memory.type
        • pool renamed to jvm.memory.pool.name
    • Garbage collection metrics
      • process.runtime.jvm.gc.duration renamed to jvm.gc.duration
      • Metric attributes
        • name renamed to jvm.gc.name
        • action renamed to jvm.gc.action
    • Thread metrics
      • process.runtime.jvm.threads.count renamed to jvm.threads.count
      • Metric attributes
        • daemon renamed to jvm.thread.daemon
    • Classes metrics
      • process.runtime.jvm.classes.loaded renamed to jvm.classes.loaded
      • process.runtime.jvm.classes.unloaded renamed to jvm.classes.unloaded

... (truncated)

Commits
  • 39e7e9c [release/v2.0.x] Prepare release 2.0.0 (#10228)
  • 8141b20 Change log for 2.0.0 (#10177)
  • f1ed419 Disable lettuce CONNECT spans by default (#10215)
  • c418b14 Don't append signal path to signal specific endpoint (#10214)
  • 6fde05d chore(deps): update plugin org.gradle.toolchains.foojay-resolver-convention t...
  • 36ed203 Apply both serverAttributes & networkAttributes to Lettuce 5.1 (#10197)
  • e843d08 fix(deps): update dependency io.r2dbc:r2dbc-proxy to v1.1.4.release (#10218)
  • b5fd786 fix(deps): update dependency io.grpc:grpc-bom to v1.61.0 (#10220)
  • 3948204 Update the OpenTelemetry SDK version to 1.34.1 (#10217)
  • 32ea07c Change Spring starter default otlp protocol from gRPC to http/protobuf (#10212)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 25, 2024
@dependabot dependabot bot force-pushed the dependabot/gradle/opentelemetryJavaagent-2.0.0 branch from 4f409d5 to 3e14e23 Compare January 25, 2024 13:27
Bumps `opentelemetryJavaagent` from 1.32.0 to 2.0.0.

Updates `io.opentelemetry.javaagent:opentelemetry-javaagent` from 1.32.0 to 2.0.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-java-instrumentation@v1.32.0...v2.0.0)

Updates `io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom` from 1.32.0 to 2.0.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-java-instrumentation@v1.32.0...v2.0.0)

---
updated-dependencies:
- dependency-name: io.opentelemetry.javaagent:opentelemetry-javaagent
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/opentelemetryJavaagent-2.0.0 branch from 3e14e23 to d33b181 Compare January 25, 2024 14:31
@SylvainJuge
Copy link
Member

This might become blocking as re-using the latest version of contrib repo will be needed for GCP resource detection #27 and mixing a more recent version of a module in contrib that might be using the latest otel API/SDK version and an agent that is slightly behind is probably a recommended option.

Being able to use the 2.x agent ensures that we can use the latest version of all the other components as the latest version of the upstream agent does.

@SylvainJuge
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 9, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@SylvainJuge SylvainJuge self-assigned this Feb 12, 2024
@@ -47,11 +48,10 @@ public void healthcheck() throws InterruptedException {
List<ExportTraceServiceRequest> traces = waitForTraces();
List<Span> spans = getSpans(traces).toList();
assertThat(spans)
.hasSize(2)
.hasSize(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant change from the otel 2.0.0 changelog:

Controller spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I should probably have read the release notes in more detail !

Here I'll leave it in the most simple form as we just need to assert that we have at least one span, and there is no need to verify that the controller span is created.

@SylvainJuge SylvainJuge merged commit 8985178 into main Feb 12, 2024
3 checks passed
@dependabot dependabot bot deleted the dependabot/gradle/opentelemetryJavaagent-2.0.0 branch February 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants