-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump opentelemetryJavaagent from 1.32.0 to 2.0.0 #96
build: bump opentelemetryJavaagent from 1.32.0 to 2.0.0 #96
Conversation
4f409d5
to
3e14e23
Compare
Bumps `opentelemetryJavaagent` from 1.32.0 to 2.0.0. Updates `io.opentelemetry.javaagent:opentelemetry-javaagent` from 1.32.0 to 2.0.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-java-instrumentation@v1.32.0...v2.0.0) Updates `io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom` from 1.32.0 to 2.0.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-java-instrumentation@v1.32.0...v2.0.0) --- updated-dependencies: - dependency-name: io.opentelemetry.javaagent:opentelemetry-javaagent dependency-type: direct:production update-type: version-update:semver-major - dependency-name: io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
3e14e23
to
d33b181
Compare
…ndabot/gradle/opentelemetryJavaagent-2.0.0
This might become blocking as re-using the latest version of contrib repo will be needed for GCP resource detection #27 and mixing a more recent version of a module in contrib that might be using the latest otel API/SDK version and an agent that is slightly behind is probably a recommended option. Being able to use the 2.x agent ensures that we can use the latest version of all the other components as the latest version of the upstream agent does. |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
…ndabot/gradle/opentelemetryJavaagent-2.0.0
@@ -47,11 +48,10 @@ public void healthcheck() throws InterruptedException { | |||
List<ExportTraceServiceRequest> traces = waitForTraces(); | |||
List<Span> spans = getSpans(traces).toList(); | |||
assertThat(spans) | |||
.hasSize(2) | |||
.hasSize(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant change from the otel 2.0.0 changelog:
Controller spans are now disabled by default. You can enable them using OTEL_INSTRUMENTATION_COMMON_EXPERIMENTAL_CONTROLLER_TELEMETRY_ENABLED=true or -Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I should probably have read the release notes in more detail !
Here I'll leave it in the most simple form as we just need to assert that we have at least one span, and there is no need to verify that the controller span is created.
smoke-tests/src/test/java/com/example/javaagent/smoketest/SmokeTest.java
Show resolved
Hide resolved
…pentelemetryJavaagent-2.0.0
Bumps
opentelemetryJavaagent
from 1.32.0 to 2.0.0.Updates
io.opentelemetry.javaagent:opentelemetry-javaagent
from 1.32.0 to 2.0.0Release notes
Sourced from io.opentelemetry.javaagent:opentelemetry-javaagent's releases.
... (truncated)
Changelog
Sourced from io.opentelemetry.javaagent:opentelemetry-javaagent's changelog.
... (truncated)
Commits
39e7e9c
[release/v2.0.x] Prepare release 2.0.0 (#10228)8141b20
Change log for 2.0.0 (#10177)f1ed419
Disable lettuce CONNECT spans by default (#10215)c418b14
Don't append signal path to signal specific endpoint (#10214)6fde05d
chore(deps): update plugin org.gradle.toolchains.foojay-resolver-convention t...36ed203
Apply both serverAttributes & networkAttributes to Lettuce 5.1 (#10197)e843d08
fix(deps): update dependency io.r2dbc:r2dbc-proxy to v1.1.4.release (#10218)b5fd786
fix(deps): update dependency io.grpc:grpc-bom to v1.61.0 (#10220)3948204
Update the OpenTelemetry SDK version to 1.34.1 (#10217)32ea07c
Change Spring starter default otlp protocol from gRPC to http/protobuf (#10212)Updates
io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom
from 1.32.0 to 2.0.0Release notes
Sourced from io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom's releases.
... (truncated)
Changelog
Sourced from io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom's changelog.
... (truncated)
Commits
39e7e9c
[release/v2.0.x] Prepare release 2.0.0 (#10228)8141b20
Change log for 2.0.0 (#10177)f1ed419
Disable lettuce CONNECT spans by default (#10215)c418b14
Don't append signal path to signal specific endpoint (#10214)6fde05d
chore(deps): update plugin org.gradle.toolchains.foojay-resolver-convention t...36ed203
Apply both serverAttributes & networkAttributes to Lettuce 5.1 (#10197)e843d08
fix(deps): update dependency io.r2dbc:r2dbc-proxy to v1.1.4.release (#10218)b5fd786
fix(deps): update dependency io.grpc:grpc-bom to v1.61.0 (#10220)3948204
Update the OpenTelemetry SDK version to 1.34.1 (#10217)32ea07c
Change Spring starter default otlp protocol from gRPC to http/protobuf (#10212)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)