elastic-opentelemetry-instrumentation-openai: rewrite tests in pytest style #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
force-pushed
the
rewrite-tests-in-pytest
branch
from
17edad3 to
e36160b
Compare
… style And start testing against azure openai. I've simplified env variables needed for vcr recordings to these: * `OPENAI_API_KEY`, with project tokens no need for the others And for azure these ones that are available for cut and paste from the interface: * `AZURE_CHAT_COMPLETIONS_DEPLOYMENT_URL` * `AZURE_CHAT_COMPLETIONS_API_KEY` * `AZURE_EMBEDDINGS_DEPLOYMENT_URL` * `AZURE_EMBEDDINGS_API_KEY`
xrmx
force-pushed
the
rewrite-tests-in-pytest
branch
from
8e5e539 to
f0ac7f7
Compare
jackshirazi
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
And start testing against azure openai.
I've simplified env variables needed for vcr recordings to these:
OPENAI_API_KEY, with project tokens no need for the othersAnd for azure these ones that are available for cut and paste from the interface:
AZURE_CHAT_COMPLETIONS_DEPLOYMENT_URLAZURE_CHAT_COMPLETIONS_API_KEYAZURE_EMBEDDINGS_DEPLOYMENT_URLAZURE_EMBEDDINGS_API_KEYRelated issues