elastic-opentelemetry-instrumentation-openai: add integrations tests and test on baseline #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.26.0 is required for having usage data with streams but with some small changes we can keep the baseline as old as 1.2.0.
…tests This adds a bunch of integration tests hitting openai. This requires setting a variable `OPENAI_API_KEY` in github secrets. Tests themselves are a copy of the recorded ones asserting values from the response data. Integration tests are not run by default and can be called with `pytest --integration-tests`
xrmx
force-pushed
the
better-testing-2
branch
from
b36b5ca to
2dd8931
Compare
trentm
approved these changes
Nov 14, 2024
instrumentation/elastic-opentelemetry-instrumentation-openai/tests/test_chat_completions.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This adds a bunch of integration tests hitting openai. This requires
setting a variable OPENAI_API_KEY in github secrets. Tests themselves
are a copy of the recorded ones asserting values from the response data.
Integration tests are not run by default and can be called with pytest --integration-tests
Then adds unit testing against 1.2.0 baseline. 1.26.0 is required for having usage data with streams but with some
small changes we can keep the baseline as old as 1.2.0.
Related issues