Skip to content

Commit

Permalink
Update tests to be independent from env vars defined in CI
Browse files Browse the repository at this point in the history
  • Loading branch information
mrodm committed Sep 3, 2024
1 parent ebf4f95 commit acc048b
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions internal/install/application_configuration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package install

import (
"os"
"testing"

"github.com/stretchr/testify/assert"
Expand Down Expand Up @@ -52,8 +53,12 @@ func TestSelectElasticAgentImageName_NextStackInOwnNamespace(t *testing.T) {
assert.Equal(t, selected, elasticAgentCompleteImageName)
}

func TestSelectElasticAgentImageName_DefaultImage816(t *testing.T) {
func TestSelectElasticAgentImageName_DefaultImage816_WihtoutEnvVar(t *testing.T) {
version := stackVersion8160
// Try to keep the test agnostic from the environment variables defined in CI
t.Setenv(disableElasticAgentWolfiEnvVar, "")
os.Unsetenv(disableElasticAgentWolfiEnvVar)

selected := selectElasticAgentImageName(version, "")
assert.Equal(t, selected, elasticAgentCompleteImageName)
}
Expand All @@ -76,12 +81,21 @@ func TestSelectCompleteElasticAgentImageName_ForceCompleteImage(t *testing.T) {
selected := selectElasticAgentImageName(version, "complete")
assert.Equal(t, selected, elasticAgentCompleteImageName)
}
func TestSelectCompleteElasticAgentImageName_ForceDefaultImage(t *testing.T) {

func TestSelectCompleteElasticAgentImageName_ForceDefaultImage_DisabledEnvVar(t *testing.T) {
version := stackVersion8160
t.Setenv(disableElasticAgentWolfiEnvVar, "true")
selected := selectElasticAgentImageName(version, "default")
assert.Equal(t, selected, elasticAgentCompleteImageName)
}

func TestSelectCompleteElasticAgentImageName_ForceDefaultImage_EnabledEnvVar(t *testing.T) {
version := stackVersion8160
t.Setenv(disableElasticAgentWolfiEnvVar, "false")
selected := selectElasticAgentImageName(version, "default")
assert.Equal(t, selected, elasticAgentWolfiImageName)
}

func TestSelectCompleteElasticAgentImageName_ForceDefaultImageOldStack(t *testing.T) {
version := "8.15.0-SNAPSHOT"
selected := selectElasticAgentImageName(version, "default")
Expand Down

0 comments on commit acc048b

Please sign in to comment.