Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in CI with docker-compose v2 #1116

Closed
jsoriano opened this issue Jan 26, 2023 · 0 comments · Fixed by elastic/integrations#5981
Closed

Run tests in CI with docker-compose v2 #1116

jsoriano opened this issue Jan 26, 2023 · 0 comments · Fixed by elastic/integrations#5981
Assignees

Comments

@jsoriano
Copy link
Member

jsoriano commented Jan 26, 2023

CI is currently using docker compose v1, but docker compose v2 is better maintained and currently quite mature. v2 is already the default in Docker for Mac. Last version of docker-compose v1 was released almost two years ago (v1.29.2).

Despite being mostly compatible, v1 and v2 have subtle differences, like the ones found in #1114 and #748.

We might consider running tests with both versions, but not sure if it is worth it as v1 is officially end of life.

Current CI:

[2023-01-26T01:42:49.686Z] 2023/01/26 01:42:49 DEBUG running command: /usr/local/bin/docker-compose version --short
[2023-01-26T01:42:50.388Z] 2023/01/26 01:42:50 DEBUG Determined Docker Compose version: 1.25.5, the tool will use Compose V1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants