Use latest docker-compose v2 version #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
mrodm
force-pushed
the
use_docker_compose_v2
branch
from
0bb13d2
to
9c98c27
Compare
|
Missing logs for container-logs apache package EDIT: As apache does not have any logs a part from that "attacching..." line when docker-compose v1 is used, those logs are empty when docker-compose v2 is used. |
mrodm
commented
Apr 25, 2023
Comment on lines
+183
to
+188
| versionMessage := fmt.Sprintf("Determined Docker Compose version: %v", ver) | ||
| if ver.Major() == 1 { | ||
| logger.Debugf("Determined Docker Compose version: %v, the tool will use Compose V1", ver) | ||
| versionMessage = fmt.Sprintf("%s, the tool will use Compose V1", versionMessage) | ||
| c.dockerComposeV1 = true | ||
| } | ||
| logger.Debug(versionMessage) |
There was a problem hiding this comment.
Maybe it can be dismissed the tool will use Compose V1 sentence and just lave the message Determined Docker Compose version: %v?
There was a problem hiding this comment.
Though well, it also tells if V1 implementation is being used here.
There was a problem hiding this comment.
Ok, I'll leave it adding that sentence if docker-compose version is v1.x
💚 Build Succeeded
History
cc @mrodm |
jsoriano
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables docker-compose v2 in CI.
Setting the latest version available at the time of creating this PR (2.17.2)
https://docs.docker.com/compose/release-notes/
Relates #1116