Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename config to policy and dataset to data stream #116

Merged
merged 8 commits into from
Sep 30, 2020
Merged

Rename config to policy and dataset to data stream #116

merged 8 commits into from
Sep 30, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Sep 28, 2020 •
edited
Loading

This PR updates the elastic-package to the changes we plan to introduce to the Elastic stack:

  1. Rename config to policy.
  2. Rename dataset to data streams.

There are lots of changes and

Note: go.mod is temporarily set to this branch: elastic/package-spec#50

@mtojek mtojek self-assigned this Sep 28, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 28, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #116 updated, Pull request #116 updated]

  • Start Time: 2020-09-30T11:53:14.486+0000

  • Duration: 8 min 45 sec

@mtojek mtojek marked this pull request as ready for review September 30, 2020 11:44
mtojek and others added 3 commits September 30, 2020 13:52
@mtojek @ycombinator
Update internal/testrunner/testrunner.go
f1945d1 
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
@mtojek @ycombinator
Update internal/testrunner/testrunner.go
8f084bf 
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
@mtojek @ycombinator
Update internal/testrunner/testrunner.go
d45deee 
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
ycombinator
ycombinator approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mtojek mtojek merged commit 860bce7 into elastic:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

@ruflin ruflin Awaiting requested review from ruflin

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ycombinator