Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run format on check #1936

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jsoriano
Copy link
Member

Running format on check modifies the working copy in an unexpected moment. This is problematic for example for coverage, as tests run check indirectly, so the resulting coverage may not fit the actual files.

@jsoriano jsoriano self-assigned this Jun 28, 2024
@jsoriano
Copy link
Member Author

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repository to test this version. Check elastic/integrations#10292

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 28, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @jsoriano

@jsoriano jsoriano marked this pull request as ready for review July 1, 2024 11:25
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsoriano jsoriano merged commit 10713d1 into elastic:main Jul 1, 2024
3 checks passed
@jsoriano jsoriano deleted the remove-formatting-from-check branch July 1, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants