Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add services name to containers logged while waiting for healthy #1990

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

jsoriano
Copy link
Member

While investigating issues in the sql_input package I missed being able to see
what was the service that was failing to start, in the previous version the logs
only included the ID, what cannot be correlated with the service when running
in CI.

Take also the opportunity to refactor labels to use a struct instead of a map
for known labels.

@jsoriano jsoriano self-assigned this Jul 26, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 26, 2024

💔 Build Failed

Failed CI Steps

History

cc @jsoriano

@jsoriano jsoriano requested a review from a team July 26, 2024 13:33
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsoriano jsoriano merged commit bce51fd into elastic:main Jul 30, 2024
3 checks passed
@jsoriano jsoriano deleted the unhealthy-services-name branch July 30, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants