Deprecate agent service deployer #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Aug 5, 2024
| @@ -70,7 +70,7 @@ func NewCustomAgentDeployer(options CustomAgentDeployerOptions) (*CustomAgentDep | |||
|
|
|||
| // SetUp sets up the service and returns any relevant information. | |||
| func (d *CustomAgentDeployer) SetUp(ctx context.Context, svcInfo ServiceInfo) (DeployedService, error) { | |||
| logger.Debug("setting up service using Docker Compose service deployer") | |||
| logger.Debug("DEPRECATED - setting up service using Docker Compose service deployer") | |||
There was a problem hiding this comment.
Could it be added something else?
There was a problem hiding this comment.
We should increase the log level, at least to be a warning.
There was a problem hiding this comment.
Sure, I forgot about the log level.
Thanks!
mrodm
commented
Aug 5, 2024
| @@ -110,7 +110,7 @@ volumes: | |||
|
|
|||
| ### Agent service deployer | |||
|
|
|||
| **NOTE**: To be deprecated soon in favor of creating new Elastic Agents in each test (technical preview yet). These | |||
| **NOTE**: Deprecated in favor of creating [new Elastic Agents in each test](#running-a-system-test). These | |||
There was a problem hiding this comment.
I was thinking to update also the subsection title , but maybe it is referenced somewhere else.
|
/test |
jsoriano
approved these changes
Aug 5, 2024
💚 Build Succeeded
History
cc @mrodm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate Agent service deployer in favor of independent Elastic Agents.
This PR also updates the documentation about system testing to remove references about the technical preview of independent Elastic Agents.