Update cleanup to remove service logs from independent Elastic Agents

[mrodm]

Update elastic-package cleanup to remove also service logs folders created for independent Elastic Agents.

Tested with nginx (from test package) and sql_input (from integrations repository).

How to test locally

elastic-package stack up -v -d

cd test/packages/parallel/nginx

# run tests and press Ctrl-C once the process is waiting for elastic-agent containers to be healthy
elastic-package test system -v

# check that some folders have been created in the profile default folder:
ls -l ~/.elastic-package/profiles/default/service_logs

# for instance
# drwxr-xr-x 2 user user 4096 ago 28 12:40 agent-nginx-access-85847
# drwxr-xr-x 2 user user 4096 ago 28 12:40 agent-nginx-error-59191
# drwxr-xr-x 2 user user 4096 ago 28 12:40 agent-nginx-stubstatus-91770

# run cleanup command
elastic-package clean -v

# the previous folders in the service logs dir should be deleted
ls -l ~/.elastic-package/profiles/default/service_logs

[mrodm]

As this package removes the built packages of the given package (folder), I tried to remove just the service logs folders for the given package.

[jsoriano]

Do we use the name of the directory for these logs directories or the name of the package in the manifest? (There are packages with names different to their directories).
Maybe we could have a function to obtain this directory path, so we use the same when creating and when deleting it.

[mrodm]

Looking at the code, it was the folder package name what it was used.
But it is true, that this was not clear and easy to know from the code.

I tried to refactor the code a little in 031c2cc to help about that.

[jsoriano]

Do we use the name of the directory for these logs directories or the name of the package in the manifest? (There are packages with names different to their directories).
Maybe we could have a function to obtain this directory path, so we use the same when creating and when deleting it.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 6ce2986

History

• 💚 Build #3784 succeeded 73fb04b

cc @mrodm