Add new setting in system configuration file to set Elastic Agent image type #2044
Conversation
mrodm
force-pushed
the
run-system-tests-type-agent
branch
from
34b9a0a
to
34c21ef
Compare
| } | ||
|
|
||
| // Configuration function returns the elastic-package configuration. | ||
| func Configuration() (*ApplicationConfiguration, error) { | ||
| func Configuration(options ...ConfigurationOption) (*ApplicationConfiguration, error) { |
There was a problem hiding this comment.
Does it work without a stack version? Should it be mandatory?
| func Configuration(options ...ConfigurationOption) (*ApplicationConfiguration, error) { | |
| func Configuration(stackVersion string, options ...ConfigurationOption) (*ApplicationConfiguration, error) { |
There was a problem hiding this comment.
While doing these changes, there was an usage where it was not used stack version:
elastic-package/cmd/profiles.go
Line 81 in d8572d9
In that command, it looks like that it just checked the config file in the ~/.elastic-package directory. It's not needed there the stack versions to retrieve the images of the services.
Exactly, this branch was based on that other PR so I could test everything. |
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
|
Feel free to merge after resolving the conflicts if there is nothing significant. |
Oh, race condition, you already resolved them :D |
💚 Build Succeeded
History
cc @mrodm |
Closes #2037
Relates elastic/package-spec#788
Adds support for a new setting in the system configuration file (
agent.type). This setting will indicate which kind of Elastic Agent docker image will be used for testing in the given test.Example of this setting:
agent: base_image: complete