Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default value for disable wolfi env var #2064

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Change default value for disable wolfi env var #2064

merged 2 commits into from
Sep 3, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Sep 2, 2024 •
edited
Loading

This PR disables by default the usage of Wolfi images for Elastic Agent containers.

This could be enabled by defining/exporting this environment variable:

export ELASTIC_PACKAGE_DISABLE_ELASTIC_AGENT_WOLFI=false
elastic-package stack up -v
elastic-package test system -v
elastic-package stack down -v

@mrodm mrodm self-assigned this Sep 2, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm marked this pull request as ready for review September 2, 2024 14:00
@mrodm mrodm requested a review from a team September 2, 2024 14:00
jlind23
jlind23 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrodm mrodm merged commit a4e1303 into elastic:main Sep 3, 2024
3 checks passed
@mrodm mrodm deleted the change-default-value-wolfi-images branch September 3, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees

@mrodm mrodm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrodm @elasticmachine @jsoriano @jlind23