Enable step to run stack tests on Windows #2173
Conversation
💚 Build Succeeded
History
|
| @@ -30,7 +30,7 @@ function withDocker($version) { | |||
|
|
|||
There was a problem hiding this comment.
Current version defined in our pipeline for docker (26.1.2) is not available in chocolatey: https://community.chocolatey.org/packages/docker-engine#versionhistory
So not too much we can do there.
Probably it could be added also the flag --allow-downgrade in case it exists the next docker version we set eventually. Or just keep it as it is now.
There was a problem hiding this comment.
Current version defined in our pipeline for docker (26.1.2) is not available in chocolatey: https://community.chocolatey.org/packages/docker-engine#versionhistory
So not too much we can do there.
Is this producing any problem? Could we change to 26.1.4, that is available in chocolatey?
There was a problem hiding this comment.
It would be meaning to update also integrations repository to ensure they are running the same versions (docker and docker-compose).
I would leave it for a different issue/PR.
| # running this stack up command adds the required files under ~/.elastic-package to run afterwards "elastic-package stack down" successfully | ||
| # that uses docker-compose under the hood | ||
| go run . stack up -v -d |
There was a problem hiding this comment.
Even though this command fails, this creates the required files under ~/.elastic-package so the latest command to run stack down can run successfully.
WDYT? Is this interesting to keep it? or should we just keep stack status command as before?
There was a problem hiding this comment.
The more we can test the better. Can we do anything about the failure of stack up? Does it also fail for users?
There was a problem hiding this comment.
For the time being, I think we cannot do so much. As for instance, there are no windows images for package-registry available (I didn't check the other services).
There was a problem hiding this comment.
Ah ok, the problem was that we were not able to run the daemon in Windows in Linux mode, right?
There was a problem hiding this comment.
Exactly, that was the main issue why it was failing elastic-package stack up in windows steps in our CI.
Closes #2107
Enable again the windows step that run some tests on stack commands.