Tests for share package #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspacca
commented
Oct 19, 2021
| @@ -66,10 +70,17 @@ def kwargs(self) -> dict[str, Any]: | |||
|
|
|||
| @kwargs.setter | |||
| def kwargs(self, value: dict[str, Any]) -> None: | |||
| init_kwargs: list[str] = [key for key in value if key in self._kwargs] | |||
There was a problem hiding this comment.
validate value has all the required keys
aspacca
commented
Oct 19, 2021
| for x in value.keys(): | ||
| if x in self._kwargs: | ||
| self.__setattr__(x, value[x]) | ||
| if self.__getattribute__(x) is None: | ||
| if not self.__getattribute__(x): |
There was a problem hiding this comment.
we want to check emptiness, not None
aspacca
commented
Oct 19, 2021
| @@ -219,30 +230,31 @@ def add_input(self, new_input: Input) -> None: | |||
|
|
|||
| def parse_config(config_yaml: str) -> Config: | |||
| yaml_config = yaml.safe_load(config_yaml) | |||
| assert isinstance(yaml_config, dict) | |||
There was a problem hiding this comment.
assert proper type from config_yaml
aspacca
commented
Oct 19, 2021
|
|
||
| conf: Config = Config() | ||
|
|
||
| if "inputs" not in yaml_config or not isinstance(yaml_config["inputs"], list): | ||
| raise ValueError("No inputs provided") | ||
|
|
||
| for input_config in yaml_config["inputs"]: | ||
| if "type" not in input_config: | ||
| raise ValueError("Must be provided type for input") | ||
| if "type" not in input_config or not isinstance(input_config["type"], str): |
aspacca
commented
Oct 19, 2021
|
|
||
| if "id" not in input_config: | ||
| raise ValueError("Must be provided id for input") | ||
| if "id" not in input_config or not isinstance(input_config["id"], str): |
aspacca
commented
Oct 19, 2021
|
|
||
| current_input: Input = Input(input_type=input_config["type"], input_id=input_config["id"]) | ||
|
|
||
| if "outputs" not in input_config or not isinstance(input_config["outputs"], list): | ||
| raise ValueError("No valid outputs for input") | ||
|
|
||
| for output_config in input_config["outputs"]: | ||
| if "type" not in output_config: | ||
| raise ValueError("Must be provided type for output") | ||
| if "type" not in output_config or not isinstance(output_config["type"], str): |
aspacca
commented
Oct 19, 2021
|
|
||
| if "args" not in output_config: | ||
| raise ValueError("Must be provided args for output") | ||
| if "args" not in output_config or not isinstance(output_config["args"], dict): |
aspacca
commented
Oct 19, 2021
| @@ -50,7 +50,7 @@ def create(output: str, **kwargs: Any) -> CommonShipper: | |||
| output_builder: Callable[..., CommonShipper] = output_definition["class"] | |||
|
|
|||
| init_kwargs: list[str] = [key for key in kwargs.keys() if key in output_kwargs and kwargs[key]] | |||
| if len(init_kwargs) is not len(output_kwargs): | |||
| if len(init_kwargs) != len(output_kwargs): | |||
aspacca
commented
Oct 19, 2021
| @@ -28,7 +28,7 @@ def create(storage_type: str, **kwargs: Any) -> CommonStorage: | |||
| storage_builder: Callable[..., CommonStorage] = storage_definition["class"] | |||
|
|
|||
| init_kwargs: list[str] = [key for key in kwargs.keys() if key in storage_kwargs and kwargs[key]] | |||
| if len(init_kwargs) is not len(storage_kwargs): | |||
| if len(init_kwargs) != len(storage_kwargs): | |||
aspacca
commented
Oct 19, 2021
| @@ -1,4 +1,4 @@ | |||
| git+git://github.com/basepi/apm-agent-python.git@lambda | |||
| elastic-apm>=6.6.0,<6.7 | |||
There was a problem hiding this comment.
lambda support is now released
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
kaiyan-sheng
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.