-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move autodiscovery at handler level #106
move autodiscovery at handler level #106
Conversation
/test |
return "aws.vpcflow" | ||
elif "/WAFLogs/" in s3_object_key: | ||
return "aws.waf" | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should add a log /warning message here to tell user here are the 6 log type we support and the rest goes into generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could have but not here in my opinion. rather in the elasticsearch sipper: I will do
Enhancement
What does this PR do?
Move the integration autodiscovery feature out of the shipper component to the input component: it is now the handler responsible to set an autodiscovery callable to the input
Why is it important?
Moving the autodiscovery feature at the input level make the visibility of the integration scope available early in the code, allowing us to unlock feature like extracting records fields for cloudtrail in the storage, since now it will be possible to know at that point that the content is cloudtrail one
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.md
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs