Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup branch #115
Cleanup branch #115
Changes from 10 commits
e7ee16e
ae73c54
e56f829
91b162e
5d28092
d353299
8eb8482
5115e1a
fc2c66e
4589b29
3460fa6
866f9f6
caf1365
f12b228
b4e7232
d88b5c2
1d8b39b
0a8d635
72d1083
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravikesarwani
please, let me know if you want to improve the wording of this sentence in order to instruct the users that this specific application is not the one to be deployed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my suggestion around naming the helper macro and the application.
Macro:
Name: helper-macro-elastic-serverless-forwarder
Description:
NOTE: DO NOT DEPLOY
Deploy elastic-serverless-forwarder instead. This is a helper SAM template for the macro and not intended to be deployed on its own.
Application:
Name: helper-application-elastic-serverless-forwarder
Description:
NOTE: DO NOT DEPLOY
Deploy elastic-serverless-forwarder instead. This is a helper SAM template for the application and not intended to be deployed on its own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will replace the content, but links are not available in the SAR snippet.
Please let me know if you prefer
or
(I would rather use the link to the app in SAR, the one you've provided is region specific)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Deploy elastic-serverless-forwarder instead." is fine.