Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SHA384 hashing to event ID format #227

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Conversation

girodav
Copy link
Contributor

@girodav girodav commented Feb 2, 2023

What does this PR do?

This PR changes the event ID format to use a SHA3_384 hash of the AWS-related information we use to generate the ID (e.g S3 bucket name, kinesis stream name, etc)

Why is it important?

Some AWS resources allows to have very long names, sometimes equal to the maximum allowed ID length in Elasticsearch (e.g Cloudwatch allows log group names of 512 characters). Since we use this information to generate the ID, as is, we can generate IDs that are effectively bigger than 512 bytes (ref: https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-id-field.html)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Related issues

@girodav girodav self-assigned this Feb 2, 2023
@girodav girodav requested a review from aspacca February 2, 2023 16:22
@girodav girodav added bug Something isn't working Team:Cloud-Monitoring Label for the Cloud Monitoring team impact:critical Immediate priority; high value or cost to the product. labels Feb 2, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-03T04:37:52.467+0000

  • Duration: 43 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 423
Skipped 0
Total 423

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (30/30) 💚
Classes 100.0% (30/30) 💚
Lines 100.0% (2073/2073) 💚
Conditionals 100.0% (720/720) 💚

@@ -0,0 +1,155 @@
# Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@aspacca aspacca merged commit 508d17e into elastic:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact:critical Immediate priority; high value or cost to the product. Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants