Added SHA384 hashing to event ID format #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the event ID format to use a SHA3_384 hash of the AWS-related information we use to generate the ID (e.g S3 bucket name, kinesis stream name, etc)
Why is it important?
Some AWS resources allows to have very long names, sometimes equal to the maximum allowed ID length in Elasticsearch (e.g Cloudwatch allows log group names of 512 characters). Since we use this information to generate the ID, as is, we can generate IDs that are effectively bigger than 512 bytes (ref: https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-id-field.html)
Checklist
CHANGELOG.md
Related issues