Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed shipper cache to include output type in the key #245

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

girodav
Copy link
Contributor

@girodav girodav commented Feb 16, 2023

What does this PR do?

With the addition of Logstash as output, we might have multiple outputs defined for one input. This needs to be considered in the key space for shipper_cache

Why is it important?

If a user has a configuration like

inputs:
  - type: s3-sqs
    id: arn:aws:sqs:eu-central-1:627286350134:test-esf-sqs-s3
    json_content_type: disabled
    outputs:
      - type: logstash
        [etc]
      - type: elasticsearch
        [etc]

Shipper cache would include only one entry for arn:aws:sqs:eu-central-1:627286350134:test-esf-sqs-s3, instead of one of logstash and one for elasticsearch, if both shippers fail

@girodav girodav self-assigned this Feb 16, 2023
@girodav girodav added bug Something isn't working Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Feb 16, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-16T14:07:10.144+0000

  • Duration: 59 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 434
Skipped 0
Total 434

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (32/32) 💚
Classes 100.0% (32/32) 💚
Lines 100.0% (2207/2207) 💚
Conditionals 100.0% (760/760) 💚

@girodav
Copy link
Contributor Author

girodav commented Feb 16, 2023

/test

@girodav girodav merged commit 97137a7 into elastic:main Feb 16, 2023
@girodav girodav deleted the fix-shipper-cache branch February 16, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants