Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAM Template outputs for Lambda function ARN and IAM Role ARN #552

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

girodav
Copy link
Contributor

@girodav girodav commented Dec 7, 2023

What does this PR do?

Add the following Outputs to the SAM template:

  • ESF Lambda function ARN
  • ESF Lambda function IAM role ARN

The PR also fixes a bug within dist.sh that prevented non-gov AWS regions from being recognized correctly.

Why is it important?

It allows users to create dependent resources based on the Lambda Function ARN.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Copy link

github-actions bot commented Dec 7, 2023

File Coverage Lines Branches Missing
All files 100% 100% 100%
main_aws.py 100% 100% 100%
handlers/__init__.py 100% 100% 100%
handlers/aws/__init__.py 100% 100% 100%
handlers/aws/cloudwatch_logs_trigger.py 100% 100% 100%
handlers/aws/exceptions.py 100% 100% 100%
handlers/aws/handler.py 100% 100% 100%
handlers/aws/kinesis_trigger.py 100% 100% 100%
handlers/aws/replay_trigger.py 100% 100% 100%
handlers/aws/s3_sqs_trigger.py 100% 100% 100%
handlers/aws/sqs_trigger.py 100% 100% 100%
handlers/aws/utils.py 100% 100% 100%
share/__init__.py 100% 100% 100%
share/config.py 100% 100% 100%
share/environment.py 100% 100% 100%
share/events.py 100% 100% 100%
share/expand_event_list_from_field.py 100% 100% 100%
share/factory.py 100% 100% 100%
share/include_exlude.py 100% 100% 100%
share/json.py 100% 100% 100%
share/logger.py 100% 100% 100%
share/multiline.py 100% 100% 100%
share/secretsmanager.py 100% 100% 100%
share/utils.py 100% 100% 100%
share/version.py 100% 100% 100%
shippers/__init__.py 100% 100% 100%
shippers/composite.py 100% 100% 100%
shippers/es.py 100% 100% 100%
shippers/factory.py 100% 100% 100%
shippers/logstash.py 100% 100% 100%
shippers/shipper.py 100% 100% 100%
storage/__init__.py 100% 100% 100%
storage/decorator.py 100% 100% 100%
storage/factory.py 100% 100% 100%
storage/payload.py 100% 100% 100%
storage/s3.py 100% 100% 100%
storage/storage.py 100% 100% 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against b2818c0

@girodav girodav added the enhancement New feature or request label Dec 8, 2023
@girodav girodav marked this pull request as ready for review December 8, 2023 10:05
aspacca
aspacca previously approved these changes Dec 8, 2023
.internal/aws/cloudformation/application.yaml Outdated Show resolved Hide resolved
@girodav girodav changed the title Add SAM Template outputs for Lambda function name, Lambda function ARN and IAM Role ARN Add SAM Template outputs for Lambda function ARN and IAM Role ARN Dec 11, 2023
@girodav girodav merged commit 7af1dd8 into main Jan 17, 2024
5 checks passed
@girodav girodav deleted the enhance-sar-outputs branch January 17, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ESF lambda ARN to SAR output
2 participants