Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 config file default to empty string #90

Merged

Conversation

aspacca
Copy link
Contributor

@aspacca aspacca commented Mar 2, 2022

Enhancement

What does this PR do?

Set default S3_CONFIG_FILE env variable

Why is it important?

This helps users not to have to remember the environment variable name, see the format of the value and more easily set the S3 URI value to the config file.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Closes #85

Use cases

Screenshots

Logs

@aspacca aspacca self-assigned this Mar 2, 2022
@aspacca aspacca added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Mar 2, 2022
@elasticmachine
Copy link

elasticmachine commented Mar 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-02T02:59:04.646+0000

  • Duration: 17 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@aspacca aspacca requested a review from Udayel March 3, 2022 02:34
@aspacca aspacca merged commit 198546d into elastic:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
3 participants