fix: Use an AbortSignal for per-request timeouts #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential fix for #63, largely inspired by a community member's PR that was never merged: #55
According to an Undici core committer in this comment the issue that triggers the
MaxListenersExceededWarning
, and possibly a memory leak in some cases, is caused by attaching anEventEmitter
to each request by default when a per-request timeout is set, rather than attaching anAbortSignal
.My assumption is that an
EventEmitter
was used becauseAbortSignal
andAbortController
were not added to Node.js until v14.17.0, so we couldn't guarantee v14 users would have it. I'm not certain why usingEventEmitters
makes a difference memory-wise, but it does get rid of theMaxListenersExceededWarning
.