Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 4, 2019

This PR adds a tagged region in the Elasticsearch Hadoop Breaking changes page (https://www.elastic.co/guide/en/elasticsearch/hadoop/master/breaking-changes.html), such that content can be re-used in the Installation and Upgrade Guide (https://www.elastic.co/guide/en/elastic-stack/master/elastic-stack-breaking-changes.html).

At least one tagged region must exist to prevent build errors in the Installation and Upgrade Guide, though as is the case now for V8.0.0 it can be an empty tagged region.

At this time, the Installation and Upgrade Guide for version X only lists the breaking changes specific to that version. Since this Elasticsearch Hadoop page contains information about multiple versions, I've made the tagged regions version-specific (i.e. tag::notable-v8-breaking-changes[]).

Related to elastic/docs#789 and elastic/stack-docs#268

Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 9258363 into elastic:master Apr 5, 2019
@lcawl lcawl deleted the tag-breaking-changes branch April 5, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants