Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteSource requires optional parameters to be set. #152

Closed
sothawo opened this issue Feb 5, 2022 · 1 comment · Fixed by #292
Closed

RemoteSource requires optional parameters to be set. #152

sothawo opened this issue Feb 5, 2022 · 1 comment · Fixed by #292
Labels
Area: Specification Related to the API spec used to generate client code

Comments

@sothawo
Copy link
Contributor

sothawo commented Feb 5, 2022

When building a reindex request and setting up a co.elastic.clients.elasticsearch.core.reindex.RemoteSource, the client code requires me so set the values for username, password, connectTimeout and socketTimeout, they cannot be null.

This contradicts the description of the reindex request at https://www.elastic.co/guide/en/elasticsearch/reference/7.17/docs-reindex.html#reindex-from-remote where it's stated that the username and password are optional, and for the timeout values gives default values when they are not set.

So I think these values should be nullable when building the request (the timeout values are not the problem, I can provide the defaults there).

@swallez
Copy link
Member

swallez commented May 24, 2022

This has been fixed in PR #292, backported to version 8.2 in PR #293 and to version 7.17 in PR #294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Specification Related to the API spec used to generate client code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants