Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to current class if loading a Jsonp provider using ServiceLoader fails #173

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Mar 1, 2022

Fixes #163

Calling JsonProvider.provider() invokes ServiceLoader that tries to find an implementation from the current thread's context classloader. In some environments where the context classloader isn't correctly set, this can cause a failure to find an implementation, even if the deployment was otherwise correct.

This PR enhances the provider lookup when the standard method fails by first trying to find an implementation in the Java client's classloader, and else in the JsonP SPI library's classloader.

It also introduces the forbidden-apis build plugin to make sure we will not inadvertently reintroduce calls to JsonProvider.provider().

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

The backport to 8.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.1 8.1
# Navigate to the new working tree
cd .worktrees/backport-8.1
# Create a new branch
git switch --create backport-173-to-8.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 8389a694c022cb91de2307f65fe8a79d7e843c1e
# Push it to GitHub
git push --set-upstream origin backport-173-to-8.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.1

Then, create a pull request where the base branch is 8.1 and the compare/head branch is backport-173-to-8.1.

swallez added a commit that referenced this pull request Mar 1, 2022
…ader fails (#173) (#175)

Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request Mar 1, 2022
…ader fails (#173) (#174)

Co-authored-by: Sylvain Wallez <sylvain@elastic.co>
swallez added a commit that referenced this pull request Mar 1, 2022
swallez added a commit that referenced this pull request Mar 3, 2022
swallez added a commit that referenced this pull request Mar 3, 2022
swallez added a commit that referenced this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants