-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to current class if loading a Jsonp provider using ServiceLoader fails #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
added
Category: Enhancement
New feature or request
backport 8.0
backport 7.17
backport 8.1
labels
Mar 1, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.1 8.1
# Navigate to the new working tree
cd .worktrees/backport-8.1
# Create a new branch
git switch --create backport-173-to-8.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 8389a694c022cb91de2307f65fe8a79d7e843c1e
# Push it to GitHub
git push --set-upstream origin backport-173-to-8.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.1 Then, create a pull request where the |
swallez
added a commit
that referenced
this pull request
Mar 1, 2022
swallez
added a commit
that referenced
this pull request
Mar 3, 2022
swallez
added a commit
that referenced
this pull request
Mar 3, 2022
swallez
added a commit
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Calling
JsonProvider.provider()
invokesServiceLoader
that tries to find an implementation from the current thread's context classloader. In some environments where the context classloader isn't correctly set, this can cause a failure to find an implementation, even if the deployment was otherwise correct.This PR enhances the provider lookup when the standard method fails by first trying to find an implementation in the Java client's classloader, and else in the JsonP SPI library's classloader.
It also introduces the forbidden-apis build plugin to make sure we will not inadvertently reintroduce calls to
JsonProvider.provider()
.